On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang <hisunzhenli...@outlook.com> wrote: > > Thanks for reviewing. > > Probing is expecting to find “correct” frames, which includes those kinds of > comfort noise and NO_DATA frames mentioned in 3GPP Specifications. > > Besides, those frames are considered as normal frames while reading packets. > It seems better to take the same standard of frames in both reading and > probing. >
Can you answer the second question? Does this actually fix any files? If so, can you provide one? As mentioned above, correct or not, this patch makes the probing accept very loose bit patterns and is likely rather prone to misdetections, so no matter if its more "correct", there are other considerations here. So instead, lets start with seeing what it actually fixes. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
