Re: [FFmpeg-devel] [PATCH 1/7] avcodec/cbs: Check for overflow when reading

2020-07-05 Thread Mark Thompson
On 09/12/2019 22:25, Andreas Rheinhardt wrote: While CBS itself uses size_t for sizes, it relies on other APIs that use int for their sizes; in particular, AVBuffer uses int for their size parameters and so does GetBitContext with their number of bits. While CBS aims to be a safe API, the checks

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/cbs: Check for overflow when reading

2019-12-11 Thread Andreas Rheinhardt
On Tue, Dec 10, 2019 at 11:12 PM Andriy Gelman wrote: > On Mon, 09. Dec 23:25, Andreas Rheinhardt wrote: > > While CBS itself uses size_t for sizes, it relies on other APIs that use > > int for their sizes; in particular, AVBuffer uses int for their size > > parameters and so does GetBitContext w

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/cbs: Check for overflow when reading

2019-12-10 Thread Andriy Gelman
On Mon, 09. Dec 23:25, Andreas Rheinhardt wrote: > While CBS itself uses size_t for sizes, it relies on other APIs that use > int for their sizes; in particular, AVBuffer uses int for their size > parameters and so does GetBitContext with their number of bits. While > CBS aims to be a safe API, the