Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

On Tue, May 21, 2019 at 04:51:19PM +0200, Moritz Barsnick wrote: > (It only matters on hardware which requires double precision software > emulation, but if explicitly using float, make sure to stick to float.) It's a best practice regardless of emulation or not. Even x86 has for example much bett

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

On Thu, May 16, 2019 at 12:51:46 +0200, Lynne wrote: > > +#define STEPSIZE0.3010299957 > > Just hardcode this in the powf call. With an appended 'f'. > > +const float scale = 1.0f; > const float scale = 1.0 / 32768; 1.0f, but it doesn't matter here, as the preprocessor reduces it to flo

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

May 16, 2019, 10:43 AM by one...@gmail.com: > Signed-off-by: Paul B Mahol <> one...@gmail.com > > > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/siren.c |