On Tue, Jul 07, 2015 at 10:12:05PM +, Carl Eugen Hoyos wrote:
> Michael Niedermayer gmx.at> writes:
>
> > maybe adding the field to AVCodecInternal
> > would work and be a solution ?
>
> enc->internal is NULL in avcodec_string().
> (That was my first try.)
then i think your original patch
Michael Niedermayer gmx.at> writes:
> maybe adding the field to AVCodecInternal
> would work and be a solution ?
enc->internal is NULL in avcodec_string().
(That was my first try.)
But I also wonder why library users would
prefer to jump through loops to know if a
video stream contains Close
On Tue, Jul 07, 2015 at 12:49:23PM +, Paul B Mahol wrote:
> On 7/7/15, Carl Eugen Hoyos wrote:
> > Paul B Mahol gmail.com> writes:
> >
> >> > How can we proceed?
> >>
> >> Adding side data.
> >
> > I was under the impression that side date
> > is used for communication between different
> > l
wm4 googlemail.com> writes:
> > > Adding side data.
> >
> > I was under the impression that side date
> > is used for communication between different
> > libraries. Is that wrong?
>
> Yes.
So how can avcodec_string() use side data?
Carl Eugen
___
On Tue, 7 Jul 2015 12:35:01 + (UTC)
Carl Eugen Hoyos wrote:
> Paul B Mahol gmail.com> writes:
>
> > > How can we proceed?
> >
> > Adding side data.
>
> I was under the impression that side date
> is used for communication between different
> libraries. Is that wrong?
Yes.
> This is ab
On 7/7/15, Carl Eugen Hoyos wrote:
> Paul B Mahol gmail.com> writes:
>
>> > How can we proceed?
>>
>> Adding side data.
>
> I was under the impression that side date
> is used for communication between different
> libraries. Is that wrong?
>
> This is about storing information about video
> strea
Paul B Mahol gmail.com> writes:
> > How can we proceed?
>
> Adding side data.
I was under the impression that side date
is used for communication between different
libraries. Is that wrong?
This is about storing information about video
streams and using this information within
libavcodec.
On 7/7/15, Carl Eugen Hoyos wrote:
> Carl Eugen Hoyos ag.or.at> writes:
>
>> > > As in attached?
>> >
>> > If anything it should use the automatic accessor macros,
>>
>> I don't think that works, no setter is needed.
>>
>> > but I still find it a silly solution.
>>
>> Then please suggest another
Carl Eugen Hoyos ag.or.at> writes:
> > > As in attached?
> >
> > If anything it should use the automatic accessor macros,
>
> I don't think that works, no setter is needed.
>
> > but I still find it a silly solution.
>
> Then please suggest another solution.
Ping.
How can we proceed?
Carl
Hendrik Leppkes gmail.com> writes:
> On Mon, Jul 6, 2015 at 6:32 PM, Carl Eugen Hoyos wrote:
> > On Monday 06 July 2015 06:18:14 pm Carl Eugen Hoyos wrote:
> >> Hendrik Leppkes gmail.com> writes:
> >> > > Attached patch adds "Closed Captions" to the codec
> >> > > dump if the video stream contai
On Mon, Jul 6, 2015 at 6:32 PM, Carl Eugen Hoyos wrote:
> On Monday 06 July 2015 06:18:14 pm Carl Eugen Hoyos wrote:
>> Hendrik Leppkes gmail.com> writes:
>> > > Attached patch adds "Closed Captions" to the codec
>> > > dump if the video stream contains them.
>> >
>> > Adding fields to a public c
Anshul gmail.com> writes:
> We had long disscussion last year for same thing,
> and i ended up in libavfilter movie,
Do you mean a discussion about telling users about
Closed Captions in video streams or a discussion
about patches to implement decoding of Closed
Captions? I am (currently) on
We had long disscussion last year for same thing, and i ended up in libavfilter
movie, though i dont have any problem with this patch.
We also used side data for same thing if u want u can look in that directions.
my opinion would be to treat h264 caption in same way as it is treated in mpeg,
m
On Monday 06 July 2015 06:18:14 pm Carl Eugen Hoyos wrote:
> Hendrik Leppkes gmail.com> writes:
> > > Attached patch adds "Closed Captions" to the codec
> > > dump if the video stream contains them.
> >
> > Adding fields to a public context which should never
> > be accessed by the public is a big
Hendrik Leppkes gmail.com> writes:
> > Attached patch adds "Closed Captions" to the codec
> > dump if the video stream contains them.
>
> Adding fields to a public context which should never
> be accessed by the public is a big no-no.
What is the alternative?
Carl Eugen
On Mon, Jul 6, 2015 at 5:53 PM, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch adds "Closed Captions" to the codec dump if
> the video stream contains them.
>
Adding fields to a public context which should never be accessed by
the public is a big no-no.
- Hendrik
__
16 matches
Mail list logo
