Hendrik Leppkes <h.leppkes <at> gmail.com> writes: > On Mon, Jul 6, 2015 at 6:32 PM, Carl Eugen Hoyos wrote: > > On Monday 06 July 2015 06:18:14 pm Carl Eugen Hoyos wrote: > >> Hendrik Leppkes <h.leppkes <at> gmail.com> writes: > >> > > Attached patch adds "Closed Captions" to the codec > >> > > dump if the video stream contains them. > >> > > >> > Adding fields to a public context which should never > >> > be accessed by the public is a big no-no. > >> > >> What is the alternative? > > > > As in attached? > > If anything it should use the automatic accessor macros,
I don't think that works, no setter is needed. > but I still find it a silly solution. Then please suggest another solution. > Any API user could just check the side data of > the frames to know if CCs are available, > AVCodecContext doesn't need to track that. This sounds as if it would be a significantly higher amount of work than to check the getter function. > Its an old problem, you're trying to solve a > ffmpeg.c problem by hacking around in avcodec, > which is IMHO not a good idea. I am trying to help users. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
