Fredrik Lundkvist via ffmpeg-devel:
>>> + ret = av_reallocp(¶m->rc_stats_buffer.buf, param->rc_stats_buffer.sz);
>
>> Why realloc instead of malloc?
>
> As far as I gathered, rc_stats_buffer.buf is already allocated by SVT-AV1; if
> malloc is preferred, I can change it and test to make sure it d
To continue this discussion.
>> +av_base64_encode(avctx->stats_out, b64_size,
>> first_pass_stats.buf, first_pass_stats.sz);
> Unchecked return value.
I don’t see any non-test instance in the code base where the return value of
av_base64_encode is actually checked. Unchecked
> > + ret = av_reallocp(¶m->rc_stats_buffer.buf, param->rc_stats_buffer.sz);
> Why realloc instead of malloc?
As far as I gathered, rc_stats_buffer.buf is already allocated by SVT-AV1; if
malloc is preferred, I can change it and test to make sure it doesn’t cause any
obvious issues.
> Wouldn'
On 5/15/2024 11:14 AM, Fredrik Lundkvist via ffmpeg-devel wrote:
Currently, libsvtav1 does not send pass number or stat buffer to SVT-AV1, which
means that 2-pass encoding is not possible using FFMPEG;
if a user wants to do 2-pass encoding using SVT-AV1, they have to use
SvtAv1EncApp.
This patc
