To continue this discussion.
>> + av_base64_encode(avctx->stats_out, b64_size, >> first_pass_stats.buf, first_pass_stats.sz); > Unchecked return value. I don’t see any non-test instance in the code base where the return value of av_base64_encode is actually checked. Unchecked calls are however found in many places, f.ex. libaomenc, librav1e, and matroskadec. IMO it should be consistent across the code base, and thus stay as is in this patch. /Fredrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
