Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-28 Thread wm4
On Thu, 28 Dec 2017 13:25:45 -0300 James Almer wrote: > On 12/25/2017 2:53 PM, Rostislav Pehlivanov wrote: > > diff --git a/libavresample/avresample.h b/libavresample/avresample.h > > index 193443e2a6..57889c572c 100644 > > --- a/libavresample/avresample.h > > +++ b/libavresample/avresample.h > >

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-28 Thread James Almer
On 12/25/2017 2:53 PM, Rostislav Pehlivanov wrote: > diff --git a/libavresample/avresample.h b/libavresample/avresample.h > index 193443e2a6..57889c572c 100644 > --- a/libavresample/avresample.h > +++ b/libavresample/avresample.h > @@ -103,10 +103,10 @@ > > #define AVRESAMPLE_MAX_CHANNELS 32 >

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-28 Thread Derek Buitenhuis
On 12/25/2017 5:53 PM, Rostislav Pehlivanov wrote: > Deprecate the entire library. Merged years ago to provide compatibility > with Libav, it remained unmaintained by the FFmpeg project and duplicated > functionality provided by libswresample. > > In order to improve consistency and reduce attack

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Rostislav Pehlivanov
On 26 December 2017 at 16:57, Derek Buitenhuis wrote: > On 12/26/2017 4:52 PM, Rostislav Pehlivanov wrote: > > You didn't even bother to read the patch? Your objections have been > > addressed. > > Since your new objection is invalid, I still intent to push it. > > I said wording, which others ha

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Derek Buitenhuis
On 12/26/2017 5:03 PM, Nicolas George wrote: > Derek Buitenhuis (2017-12-26): >> It would be nice if this community moved away from the "aggressive asshole" >> style of development, as seen here, but after so many years, that just >> seems impossible. Normal people get pushed away by aggressive ass

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Nicolas George
Derek Buitenhuis (2017-12-26): > It would be nice if this community moved away from the "aggressive asshole" > style of development, as seen here, but after so many years, that just > seems impossible. Normal people get pushed away by aggressive assholes. I agree on the idea. Maybe start by not ca

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Derek Buitenhuis
On 12/26/2017 4:52 PM, Rostislav Pehlivanov wrote: > You didn't even bother to read the patch? Your objections have been > addressed. > Since your new objection is invalid, I still intent to push it. I said wording, which others had issues with, and were *not* addressed until v2 of the patch yeste

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread James Almer
On 12/26/2017 1:52 PM, Rostislav Pehlivanov wrote: > On 26 December 2017 at 16:35, Derek Buitenhuis > wrote: > >> On 12/26/2017 4:10 PM, Nicolas George wrote: >>> I missed that. If the proposal was similar enough to what was sent >>> yesterday, then my objection does not stand, of course, sorry.

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Rostislav Pehlivanov
On 26 December 2017 at 16:35, Derek Buitenhuis wrote: > On 12/26/2017 4:10 PM, Nicolas George wrote: > > I missed that. If the proposal was similar enough to what was sent > > yesterday, then my objection does not stand, of course, sorry. > > The version on the ML then was different, and it never

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Derek Buitenhuis
On 12/26/2017 4:10 PM, Nicolas George wrote: > I missed that. If the proposal was similar enough to what was sent > yesterday, then my objection does not stand, of course, sorry. The version on the ML then was different, and it never reached consensus at all on wording. I object for the reasons st

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Derek Buitenhuis
On 12/26/2017 3:54 PM, Rostislav Pehlivanov wrote: > This has been on the ML for over a month. No one disagreed then. No one was > on vacation then. I agree with Nicholas, sending a new, different version of a patch, *on Christmas Day*, and pushing on Boxing Day if nobody has objections, is not O

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Nicolas George
Rostislav Pehlivanov (2017-12-26): > This has been on the ML for over a month. No one disagreed then. No one was > on vacation then. I missed that. If the proposal was similar enough to what was sent yesterday, then my objection does not stand, of course, sorry. Regards, -- Nicolas George s

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Rostislav Pehlivanov
On 26 December 2017 at 15:47, Nicolas George wrote: > Rostislav Pehlivanov (2017-12-26): > > I'll push this tonight if there are no more objections. > > Way too soon. For a patch that sensitive, leaving a week for people to > voice their concerns and raise objections that you may not have thought

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Nicolas George
Rostislav Pehlivanov (2017-12-26): > I'll push this tonight if there are no more objections. Way too soon. For a patch that sensitive, leaving a week for people to voice their concerns and raise objections that you may not have thought of seems like a reasonable minimum. Plus we are on vacation pe

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-26 Thread Rostislav Pehlivanov
On 25 December 2017 at 17:53, Rostislav Pehlivanov wrote: > Deprecate the entire library. Merged years ago to provide compatibility > with Libav, it remained unmaintained by the FFmpeg project and duplicated > functionality provided by libswresample. > > In order to improve consistency and reduce

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-25 Thread Clément Bœsch
On Mon, Dec 25, 2017 at 11:57:31AM +, Rostislav Pehlivanov wrote: [...] > > What you call "dead project" did basically all of the hardware > > transcoding improvements that were merged into ffmpeg. How very > > insincere of you. > > > > Didn't mean dead as an offense, just as an honest fact. H

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-25 Thread Rostislav Pehlivanov
On 25 December 2017 at 11:03, wm4 wrote: > On Mon, 25 Dec 2017 10:44:40 + > Rostislav Pehlivanov wrote: > > > On 25 December 2017 at 06:50, wm4 wrote: > > > > > On Mon, 25 Dec 2017 02:12:38 + > > > Rostislav Pehlivanov wrote: > > > > > > > Signed-off-by: Rostislav Pehlivanov > > > > -

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-25 Thread wm4
On Mon, 25 Dec 2017 10:44:40 + Rostislav Pehlivanov wrote: > On 25 December 2017 at 06:50, wm4 wrote: > > > On Mon, 25 Dec 2017 02:12:38 + > > Rostislav Pehlivanov wrote: > > > > > Signed-off-by: Rostislav Pehlivanov > > > --- > > > doc/APIchanges | 5 + > > > liba

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-25 Thread Rostislav Pehlivanov
On 25 December 2017 at 06:50, wm4 wrote: > On Mon, 25 Dec 2017 02:12:38 + > Rostislav Pehlivanov wrote: > > > Signed-off-by: Rostislav Pehlivanov > > --- > > doc/APIchanges | 5 + > > libavresample/avresample.h | 30 +- > > 2 files changed, 30 i

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-24 Thread wm4
On Mon, 25 Dec 2017 02:12:38 + Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/APIchanges | 5 + > libavresample/avresample.h | 30 +- > 2 files changed, 30 insertions(+), 5 deletions(-) > > diff --git a/doc/APIchan

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-27 Thread Tobias Rapp
On 25.11.2017 18:31, Derek Buitenhuis wrote: On 11/25/2017 2:40 PM, Clément Bœsch wrote: Maybe "libavresample is not maintained by the FFmpeg project and will be dropped at the next major bump. Please use libswresample instead." And it probably needs a longer explanation somewhere (website/news

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-25 Thread Derek Buitenhuis
On 11/25/2017 2:40 PM, Clément Bœsch wrote: > Maybe "libavresample is not maintained by the FFmpeg project and will be > dropped at the next major bump. Please use libswresample instead." > > And it probably needs a longer explanation somewhere (website/news/...) All API functions should be prope

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-25 Thread Clément Bœsch
On Fri, Nov 17, 2017 at 03:58:16PM +, Rostislav Pehlivanov wrote: [...] > diff --git a/libavresample/utils.c b/libavresample/utils.c > index b4fb906556..3e629fe901 100644 > --- a/libavresample/utils.c > +++ b/libavresample/utils.c > @@ -37,6 +37,9 @@ int avresample_open(AVAudioResampleContext *

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread Rostislav Pehlivanov
On 17 November 2017 at 17:53, James Almer wrote: > On 11/17/2017 12:58 PM, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > doc/APIchanges| 5 + > > libavresample/utils.c | 3 +++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/doc/APIchanges

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread Rostislav Pehlivanov
On 17 November 2017 at 17:51, Carl Eugen Hoyos wrote: > 2017-11-17 16:58 GMT+01:00 Rostislav Pehlivanov : > > > +2017-xx-xx - xxx - lavr 4.0.0 - avresample.h > > + Deprecate the entire library. It was unmaintained and redundant > > + as libswresample did everything it did better, faster, wi

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread James Almer
On 11/17/2017 12:58 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/APIchanges| 5 + > libavresample/utils.c | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/doc/APIchanges b/doc/APIchanges > index d336f6ce22..22c7b5a0d0 100644 > --- a/do

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 16:58 GMT+01:00 Rostislav Pehlivanov : > +2017-xx-xx - xxx - lavr 4.0.0 - avresample.h > + Deprecate the entire library. It was unmaintained and redundant > + as libswresample did everything it did better, faster, with more > + control and with a better, slightly higher level API