Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

2023-12-07 Thread Martin Storsjö
On Thu, 7 Dec 2023, Mikhail Nitenko wrote: On Thu, 7 Dec 2023 at 18:03, Martin Storsjö wrote: Hi, On Mon, 4 Dec 2023, Mikhail Nitenko wrote: --- I think the patch subject is missing to tell that this adds 10 bit functions? Yes, you are right. Will you add it when you push it? Or should

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

2023-12-07 Thread Mikhail Nitenko
On Thu, 7 Dec 2023 at 18:03, Martin Storsjö wrote: > > Hi, > > On Mon, 4 Dec 2023, Mikhail Nitenko wrote: > > > --- > > I think the patch subject is missing to tell that this adds 10 bit > functions? > > > I remodeled the patch (as Martin once suggested), it doesn't > > go to 32bits in lowpass_8_1

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

2023-12-07 Thread Mikhail Nitenko
On Thu, 7 Dec 2023 at 18:03, Martin Storsjö wrote: > > Hi, > > On Mon, 4 Dec 2023, Mikhail Nitenko wrote: > > > --- > > I think the patch subject is missing to tell that this adds 10 bit > functions? Yes, you are right. Will you add it when you push it? Or should I resend the patch? (I would imag

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

2023-12-07 Thread Martin Storsjö
Hi, On Mon, 4 Dec 2023, Mikhail Nitenko wrote: --- I think the patch subject is missing to tell that this adds 10 bit functions? I remodeled the patch (as Martin once suggested), it doesn't go to 32bits in lowpass_8_10 and is also using the much faster lowpass_8_10_v. libavcodec/aarch64/

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

2021-09-03 Thread Martin Storsjö
On Fri, 3 Sep 2021, Martin Storsjö wrote: +function \type\()_h264_qpel8_v_lowpass_neon_10 +ld1 {v16.8H}, [x1], x3 +ld1 {v18.8H}, [x1], x3 +ld1 {v20.8H}, [x1], x3 +ld1 {v22.8H}, [x1], x3 +ld1 {v24.

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions

2021-09-03 Thread Martin Storsjö
On Thu, 19 Aug 2021, Mikhail Nitenko wrote: diff --git a/libavcodec/aarch64/h264qpel_neon.S b/libavcodec/aarch64/h264qpel_neon.S index d27cfac494..eb18469b7f 100644 --- a/libavcodec/aarch64/h264qpel_neon.S +++ b/libavcodec/aarch64/h264qpel_neon.S @@ -932,3 +932,518 @@ endfunc h264_qpel