On Thu, 7 Dec 2023, Mikhail Nitenko wrote:
On Thu, 7 Dec 2023 at 18:03, Martin Storsjö <mar...@martin.st> wrote:
Hi,
On Mon, 4 Dec 2023, Mikhail Nitenko wrote:
---
I think the patch subject is missing to tell that this adds 10 bit
functions?
Yes, you are right. Will you add it when you push it? Or should I
resend the patch?
(I would image it would go like "lavc/aarch64: h264qpel, add 10-bit
lowpass_8_10 based functions"
That sounds reasonable; no need to resend just for that.
This patch uses upper case element specifiers like .16B here; we
reformatted our assembly to consistenty use lower case element specifiers
in 184103b3105f02f1189fa0047af4269e027dfbd6 (also see
7f905f3672da4f1fa28d7cccf1fef7f9984e0480); I can apply this change
mechanically on this patch before pushing it.
Oh, and /sligthly/ unrelated, macros names in libavcodec/aarch64/neon.S
use uppercase, should they also be lowercase then or are they fine?
If they clearly refer to vector element specifiers, then yes, ideally. My
regexes didn't match them. I see that h264qpel_neon.S also has a macro
lowpass_8H; I presume that also should be treated similarly. (On a 5
second glance I didn't see if it referred to that or something else.)
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
