Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-10-24 Thread Michael Niedermayer
On Mon, Sep 17, 2018 at 02:35:44PM -0700, Jacob Trimble wrote: > On Wed, Sep 12, 2018 at 11:50 AM Michael Niedermayer > wrote: > > > > On Tue, Sep 11, 2018 at 03:50:57PM -0700, Jacob Trimble wrote: > > > [...] > > > > > > So how about, when we see an encrypted frame, we flush the parser > > > befo

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-10-23 Thread Jacob Trimble
On Mon, Oct 1, 2018 at 11:30 AM Jacob Trimble wrote: > > On Mon, Sep 17, 2018 at 2:35 PM Jacob Trimble wrote: > > > > On Wed, Sep 12, 2018 at 11:50 AM Michael Niedermayer > > wrote: > > > > > > On Tue, Sep 11, 2018 at 03:50:57PM -0700, Jacob Trimble wrote: > > > > [...] > > > > > > > > So how ab

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-10-01 Thread Jacob Trimble
On Mon, Sep 17, 2018 at 2:35 PM Jacob Trimble wrote: > > On Wed, Sep 12, 2018 at 11:50 AM Michael Niedermayer > wrote: > > > > On Tue, Sep 11, 2018 at 03:50:57PM -0700, Jacob Trimble wrote: > > > [...] > > > > > > So how about, when we see an encrypted frame, we flush the parser > > > before skip

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-17 Thread Jacob Trimble
On Wed, Sep 12, 2018 at 11:50 AM Michael Niedermayer wrote: > > On Tue, Sep 11, 2018 at 03:50:57PM -0700, Jacob Trimble wrote: > > [...] > > > > So how about, when we see an encrypted frame, we flush the parser > > before skipping the frame? Can we just flush the parser and then > > reuse it late

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-12 Thread Michael Niedermayer
On Tue, Sep 11, 2018 at 03:50:57PM -0700, Jacob Trimble wrote: > On Tue, Sep 11, 2018 at 1:48 PM Michael Niedermayer > wrote: > > > > On Thu, Aug 30, 2018 at 08:43:25AM -0700, Jacob Trimble wrote: > > > On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer > > > wrote: > > > > > > > > On Wed, Aug 2

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-11 Thread Jacob Trimble
On Tue, Sep 11, 2018 at 1:48 PM Michael Niedermayer wrote: > > On Thu, Aug 30, 2018 at 08:43:25AM -0700, Jacob Trimble wrote: > > On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer > > wrote: > > > > > > On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > > > > On Wed, Aug 29, 2018

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-11 Thread Michael Niedermayer
On Thu, Aug 30, 2018 at 08:43:25AM -0700, Jacob Trimble wrote: > On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer > wrote: > > > > On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > > > On Wed, Aug 29, 2018 at 3:20 PM James Almer wrote: > > > > > > > > On 8/29/2018 7:07 PM, Micha

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-11 Thread Jacob Trimble
On Thu, Aug 30, 2018 at 8:43 AM Jacob Trimble wrote: > > On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer > wrote: > > > > On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > > > On Wed, Aug 29, 2018 at 3:20 PM James Almer wrote: > > > > > > > > On 8/29/2018 7:07 PM, Michael Nied

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-08-30 Thread Jacob Trimble
On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer wrote: > > On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > > On Wed, Aug 29, 2018 at 3:20 PM James Almer wrote: > > > > > > On 8/29/2018 7:07 PM, Michael Niedermayer wrote: > > > > On Tue, Aug 28, 2018 at 10:58:43AM -0700, Jacob

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-08-29 Thread Michael Niedermayer
On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > On Wed, Aug 29, 2018 at 3:20 PM James Almer wrote: > > > > On 8/29/2018 7:07 PM, Michael Niedermayer wrote: > > > On Tue, Aug 28, 2018 at 10:58:43AM -0700, Jacob Trimble wrote: > > >> If a packet is full-sample encrypted, then packet

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-08-29 Thread Jacob Trimble
On Wed, Aug 29, 2018 at 3:20 PM James Almer wrote: > > On 8/29/2018 7:07 PM, Michael Niedermayer wrote: > > On Tue, Aug 28, 2018 at 10:58:43AM -0700, Jacob Trimble wrote: > >> If a packet is full-sample encrypted, then packet data can't be parsed > >> without decrypting it. So this skips the pack

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-08-29 Thread James Almer
On 8/29/2018 7:07 PM, Michael Niedermayer wrote: > On Tue, Aug 28, 2018 at 10:58:43AM -0700, Jacob Trimble wrote: >> If a packet is full-sample encrypted, then packet data can't be parsed >> without decrypting it. So this skips the packet parsing for those >> packets. If the packet has sub-sample

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-08-29 Thread Michael Niedermayer
On Tue, Aug 28, 2018 at 10:58:43AM -0700, Jacob Trimble wrote: > If a packet is full-sample encrypted, then packet data can't be parsed > without decrypting it. So this skips the packet parsing for those > packets. If the packet has sub-sample encryption, it is assumed that > the headers are in t