Thank you Stefano Sabatini and Andreas Rheinhardt - you guys have the patience
of saints.
On Tuesday, March 12th, 2024 at 11:27 AM, Stefano Sabatini
wrote:
> On date Sunday 2024-03-10 16:10:15 +0100, Stefano Sabatini wrote:
>
> > On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing
On date Sunday 2024-03-10 16:10:15 +0100, Stefano Sabatini wrote:
> On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing List wrote:
> > Great, thank you very much!
> > I'm attaching the (hopefully) final version of the patch.
> >
>
> > MD studio was a piece of software created by a com
On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing List wrote:
> Great, thank you very much!
> I'm attaching the (hopefully) final version of the patch.
>
> MD studio was a piece of software created by a company called "EDL",
> which in combination with alternative firmware for the So
Great, thank you very much!
I'm attaching the (hopefully) final version of the patch.
MD studio was a piece of software created by a company called "EDL", which in
combination with alternative firmware for the Sony MDH-10 MiniDisc recorder
(https://www.minidisc.wiki/equipment/sony/misc/mdh-10) l
On date Saturday 2024-03-09 17:20:49 +, ffmpeg-devel Mailing List wrote:
> Thank you both for the suggestions. I've updated the code as requested, and I
> apologize for the AV_LOG_WARNING instead of AV_LOG_ERROR - it was an
> oversight on my part.
> I have also added the stream codec check, a
I see, I've changed title_length to size_t, but left the warning as is to
inform the user in case truncation needs to take place.
On Saturday, March 9th, 2024 at 6:48 PM, Andreas Rheinhardt
wrote:
> asivery via ffmpeg-devel:
>
> > + const char *title_contents = title_entry->value;
> > + title
asivery via ffmpeg-devel:
> +const char *title_contents = title_entry->value;
> +title_length = strlen(title_contents);
> +if (title_length > 256) {
> +av_log(s, AV_LOG_WARNING, "Title too long, truncated to 256
> bytes.\n");
> +title_length = 256;
>
Thank you both for the suggestions. I've updated the code as requested, and I
apologize for the AV_LOG_WARNING instead of AV_LOG_ERROR - it was an oversight
on my part.
I have also added the stream codec check, and it did get triggered when I tried
to feed it audio that was not ATRAC1, so it see
asivery via ffmpeg-devel:
> +#include "libavutil/intreadwrite.h"
> +#include "libavutil/avstring.h"
These two headers seem unused.
> +#include "avformat.h"
> +#include "avio_internal.h"
> +#include "rawenc.h"
> +#include "mux.h"
> +
> +static int aea_write_header(AVFormatContext *s)
> +{
> +c
On date Friday 2024-03-08 13:50:59 +, ffmpeg-devel Mailing List wrote:
> Thank you for your incredibly thorough and fast response. I've applied all
> the corrections you requested. Please let me know if there's anything else
> wrong with my patch, and thank you for your time.
>
> - asivery
Thank you for your incredibly thorough and fast response. I've applied all the
corrections you requested. Please let me know if there's anything else wrong
with my patch, and thank you for your time.
- asivery
On Friday, March 8th, 2024 at 1:06 PM, Andreas Rheinhardt
wrote:
> asivery via ffm
asivery via ffmpeg-devel:
> +typedef struct {
> +int block_count;
> +} AeaMuxerContext;
> +
> +static int aea_init(AVFormatContext *s)
> +{
> +AeaMuxerContext *c = s->priv_data;
> +c->block_count = 0;
Unnecessary: A muxer's priv_data is always pre-zeroed.
> +
> +return 0;
> +}
Apologies for my oversight.
I've attached the new patch.
- asivery
On Friday, March 8th, 2024 at 12:22 PM, Andreas Rheinhardt
wrote:
> asivery via ffmpeg-devel:
>
> > diff --git a/libavformat/allformats.c b/libavformat/allformats.c
> > index b04b43cab3..1a50181447 100644
> > --- a/libavforma
asivery via ffmpeg-devel:
> diff --git a/libavformat/allformats.c b/libavformat/allformats.c
> index b04b43cab3..1a50181447 100644
> --- a/libavformat/allformats.c
> +++ b/libavformat/allformats.c
> @@ -46,6 +46,7 @@ extern const FFOutputFormat ff_adts_muxer;
> extern const AVInputFormat ff_adx_d
14 matches
Mail list logo
