On date Saturday 2024-03-09 17:20:49 +0000, ffmpeg-devel Mailing List wrote:
> Thank you both for the suggestions. I've updated the code as requested, and I
> apologize for the AV_LOG_WARNING instead of AV_LOG_ERROR - it was an
> oversight on my part.
> I have also added the stream codec check, and it did get triggered when I
> tried to feed it audio that was not ATRAC1, so it seems it is required.
> Regarding titles being truncated - that was my intention. However I've now
> added a warning if it was going to happen.
> As for the block count in the header - none of the modern software which uses
> AEA reads that field, but for the older software, it will now be truncated to
> UINT32_MAX if needed.
> Is there anything else that needs changes?
>
> From ee1d4c93c66e729d9d0456b2e8e789f3f98389e3 Mon Sep 17 00:00:00 2001
> From: asivery <asiv...@protonmail.com>
> Date: Fri, 8 Mar 2024 14:45:02 +0100
> Subject: [PATCH] avformat/aea: Add aea muxer
>
> Signed-off-by: asivery <asiv...@protonmail.com>
> ---
> doc/muxers.texi | 10 +++
> libavformat/Makefile | 3 +-
> libavformat/{aea.c => aeadec.c} | 0
> libavformat/aeaenc.c | 115 ++++++++++++++++++++++++++++++++
> libavformat/allformats.c | 1 +
> 5 files changed, 128 insertions(+), 1 deletion(-)
> rename libavformat/{aea.c => aeadec.c} (100%)
> create mode 100644 libavformat/aeaenc.c
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index 2104cc4a95..a4df8f736d 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -663,6 +663,16 @@ when enabled, write a CRC checksum for each packet to
> the output,
> default is @code{false}
> @end table
>
> +@anchor{aea}
> +@section aea
nit: sort order (should go after adts)
> +MD STUDIO audio muxer.
out of my own curiosity, what is MD STUDIO?
[...]
You might also add an entry to the Changelog.
Looks good to me otherwise, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
