Re: [FFmpeg-devel] [PATCH] avcodec/omx: fix xFramerate calculation

2019-08-30 Thread Aman Gupta
On Thu, Aug 29, 2019 at 10:30 PM Nicolas George wrote: > Aman Gupta (12019-08-29): > > > > -in_port_params.format.video.xFramerate = (1 << 16) * > > > avctx->framerate.num / avctx->framerate.den; > > > > +in_port_params.format.video.xFramerate = (int64_t)(1 << 16) > * > > > avctx-

Re: [FFmpeg-devel] [PATCH] avcodec/omx: fix xFramerate calculation

2019-08-29 Thread Nicolas George
Aman Gupta (12019-08-29): > > > -in_port_params.format.video.xFramerate = (1 << 16) * > > avctx->framerate.num / avctx->framerate.den; > > > +in_port_params.format.video.xFramerate = (int64_t)(1 << 16) * > > avctx->framerate.num / avctx->framerate.den; > > > > change 1 > 1LL is more

Re: [FFmpeg-devel] [PATCH] avcodec/omx: fix xFramerate calculation

2019-08-29 Thread Aman Gupta
On Thu, Aug 29, 2019 at 5:56 PM Limin Wang wrote: > On Thu, Aug 29, 2019 at 05:30:25PM -0700, Aman Gupta wrote: > > From: Aman Gupta > > > > Integer overflow in the Q16 framerate calculation was sending > > invalid values to the OMX encoder. > > > > On the RPI4, this manifested as bitrate contro

Re: [FFmpeg-devel] [PATCH] avcodec/omx: fix xFramerate calculation

2019-08-29 Thread Limin Wang
On Thu, Aug 29, 2019 at 05:30:25PM -0700, Aman Gupta wrote: > From: Aman Gupta > > Integer overflow in the Q16 framerate calculation was sending > invalid values to the OMX encoder. > > On the RPI4, this manifested as bitrate controls being ignored > on video streams with 6/1001 framerates.