Aman Gupta (12019-08-29): > > > - in_port_params.format.video.xFramerate = (1 << 16) * > > avctx->framerate.num / avctx->framerate.den; > > > + in_port_params.format.video.xFramerate = (int64_t)(1 << 16) * > > avctx->framerate.num / avctx->framerate.den; > > > > change 1 > 1LL is more simple to solve the overflow. > > Great, thank you for the tip! Updated my local patch accordingly.
This remark looks weird: using long long directly is almost never correct code. And in this particular case, av_rescale_q() seems the correct choice. Regards, -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".