Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Ganesh Ajjanagadde
On Fri, Dec 18, 2015 at 1:11 AM, Kacper Michajlow wrote: > 18 gru 2015 10:06 AM "Kacper Michajlow" napisał(a): >> >> One minor nitpick about commit message. You could mention which compiler > was used to generate code for benchmark. For example Clang 3.7 replaces > pow(2,...) with exp2(...) call

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
18 gru 2015 10:06 AM "Kacper Michajlow" napisał(a): > > One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So you probably did use gcc. Anyway since it is already

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So you probably did use gcc. Anyway since it is already merged I guess take my reply as a hint for next time :)

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-17 Thread Ganesh Ajjanagadde
On Tue, Dec 15, 2015 at 6:40 PM, Ganesh Ajjanagadde wrote: > On Tue, Dec 15, 2015 at 5:25 PM, Ganesh Ajjanagadde wrote: >> On Tue, Dec 15, 2015 at 2:23 AM, Michael Niedermayer >> wrote: >>> On Wed, Dec 09, 2015 at 06:55:25PM -0500, Ganesh Ajjanagadde wrote: > [...] diff --git a/libavc

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-15 Thread Ganesh Ajjanagadde
On Tue, Dec 15, 2015 at 5:25 PM, Ganesh Ajjanagadde wrote: > On Tue, Dec 15, 2015 at 2:23 AM, Michael Niedermayer wrote: >> On Wed, Dec 09, 2015 at 06:55:25PM -0500, Ganesh Ajjanagadde wrote: [...] >>> >>> diff --git a/libavcodec/nellymoserenc.c b/libavcodec/nellymoserenc.c >>> index d998dba..e60

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-15 Thread Ganesh Ajjanagadde
On Tue, Dec 15, 2015 at 2:23 AM, Michael Niedermayer wrote: > On Wed, Dec 09, 2015 at 06:55:25PM -0500, Ganesh Ajjanagadde wrote: >> exp2 suffices here. Some trivial (~ 4x) speedup is done in addition here by >> reusing results. >> > >> This is bit-identical to the old values. > > That may be true

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-14 Thread Michael Niedermayer
On Wed, Dec 09, 2015 at 06:55:25PM -0500, Ganesh Ajjanagadde wrote: > exp2 suffices here. Some trivial (~ 4x) speedup is done in addition here by > reusing results. > > This is bit-identical to the old values. That may be true with a specific compiler and version but C makes no such guarantee un

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-14 Thread Ganesh Ajjanagadde
On Wed, Dec 9, 2015 at 6:55 PM, Ganesh Ajjanagadde wrote: > exp2 suffices here. Some trivial (~ 4x) speedup is done in addition here by > reusing results. > > This is bit-identical to the old values. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/nellymoserenc.c | 11 +-- > 1 f