Re: [FFmpeg-devel] [PATCH] Add vps/sps/pps id set to hevc_metadata bsf

2020-01-08 Thread Moritz Barsnick
On Tue, Jan 07, 2020 at 15:24:53 +0200, Eran Gonen wrote: > Thanks, I will fix that. What's the formatter parameters for that? (AStyle > or other) See https://www.ffmpeg.org/developer.html#Coding-Rules-1 $ indent -i4 -kr -nut (approximately) I haven't used astyle so much (only trial-and-error), b

Re: [FFmpeg-devel] [PATCH] Add vps/sps/pps id set to hevc_metadata bsf

2020-01-07 Thread Eran Gonen
Thanks, I will fix that. What's the formatter parameters for that? (AStyle or other) On Tue, Jan 7, 2020 at 2:02 PM Moritz Barsnick wrote: > On Tue, Jan 07, 2020 at 10:51:55 +0200, Eran Gonen wrote: > > Subject: Add vps/sps/pps id set to hevc_metadata bsf > > Please use: > avcodec/h265_metadata_

Re: [FFmpeg-devel] [PATCH] Add vps/sps/pps id set to hevc_metadata bsf

2020-01-07 Thread Moritz Barsnick
On Tue, Jan 07, 2020 at 10:51:55 +0200, Eran Gonen wrote: > Subject: Add vps/sps/pps id set to hevc_metadata bsf Please use: avcodec/h265_metadata_bsf: [...] > +if(ctx->vps_id > -1) { Code style: "if (" (i.e. space before the bracket here). Also in various other places in your code. > +