On Tue, Jan 07, 2020 at 10:51:55 +0200, Eran Gonen wrote:
> Subject: Add vps/sps/pps id set to hevc_metadata bsf
Please use:
avcodec/h265_metadata_bsf: [...]
> + if(ctx->vps_id > -1) {
Code style: "if (" (i.e. space before the bracket here).
Also in various other places in your code.
> + case HEVC_NAL_VPS:
> + err = h265_metadata_update_vps(bsf, au->units[i].content);
> + if (err < 0)
> + goto fail;
> + break;
Incorrect indentation. (Also the other "break"s.)
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
