Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-27 Thread Paras Chadha
On Fri, Jul 21, 2017 at 7:59 PM, Nicolas George wrote: > Le tridi 3 thermidor, an CCXXV, Paras Chadha a écrit : > > > > AVOutputFormat ff_image2pipe_muxer = { > > > > .name = "image2pipe", > > > > .long_name = NULL_IF_CONFIG_SMALL("piped image2 sequence"), > > > > +.

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-27 Thread Paras Chadha
On Mon, Jul 24, 2017 at 3:42 AM, Carl Eugen Hoyos wrote: > 2017-07-21 20:16 GMT+02:00 Reimar Döffinger : > > On 21.07.2017, at 16:26, Paras Chadha wrote: > > > >> On Fri, Jul 21, 2017 at 3:27 AM, Carl Eugen Hoyos > >> wrote: > >> > >>> 2017-07-20 21:46 GMT+02:00 Paras Chadha : > >>> > +

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-23 Thread Carl Eugen Hoyos
2017-07-21 20:16 GMT+02:00 Reimar Döffinger : > On 21.07.2017, at 16:26, Paras Chadha wrote: > >> On Fri, Jul 21, 2017 at 3:27 AM, Carl Eugen Hoyos >> wrote: >> >>> 2017-07-20 21:46 GMT+02:00 Paras Chadha : >>> +case AV_PIX_FMT_RGB24: +case AV_PIX_FMT_RGBA:

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-21 Thread Reimar Döffinger
On 21.07.2017, at 16:26, Paras Chadha wrote: > On Fri, Jul 21, 2017 at 3:27 AM, Carl Eugen Hoyos > wrote: > >> 2017-07-20 21:46 GMT+02:00 Paras Chadha : >> >>> +case AV_PIX_FMT_RGB24: >>> +case AV_PIX_FMT_RGBA: >>> +for (k = 0; k < naxis3; k++) { >>> +

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-21 Thread Nicolas George
Le tridi 3 thermidor, an CCXXV, Paras Chadha a écrit : > > > AVOutputFormat ff_image2pipe_muxer = { > > > .name = "image2pipe", > > > .long_name = NULL_IF_CONFIG_SMALL("piped image2 sequence"), > > > +.extensions = "fits", > > This is probably wrong. Did you intend

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-21 Thread Paras Chadha
On Fri, Jul 21, 2017 at 3:27 AM, Carl Eugen Hoyos wrote: > 2017-07-20 21:46 GMT+02:00 Paras Chadha : > > > +case AV_PIX_FMT_RGB24: > > +case AV_PIX_FMT_RGBA: > > +for (k = 0; k < naxis3; k++) { > > +for (i = 0; i < avctx->height; i++) {

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-21 Thread Paras Chadha
On Fri, Jul 21, 2017 at 1:45 AM, James Almer wrote: > On 7/20/2017 4:46 PM, Paras Chadha wrote: > > diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c > > index 1297b1a..25283cc 100644 > > --- a/libavformat/img2enc.c > > +++ b/libavformat/img2enc.c > > @@ -237,6 +237,7 @@ AVOutputFormat f

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-20 Thread Carl Eugen Hoyos
2017-07-20 21:46 GMT+02:00 Paras Chadha : > +case AV_PIX_FMT_RGB24: > +case AV_PIX_FMT_RGBA: > +for (k = 0; k < naxis3; k++) { > +for (i = 0; i < avctx->height; i++) { > +ptr = p->data[0] + (avctx->height - i - 1)

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-20 Thread James Almer
On 7/20/2017 4:46 PM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > > Made the changes suggested. > > doc/general.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 +- > libavcodec/fitsenc.c | 237 > +

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 15:08, Nicolas George wrote: > L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : >> Why is there no decoder? > > Because the decoder is in a separate patch, and the demuxer in yet > another. And none of them can proceed until Paras Chadha starts deciding > what is cons

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 14:31, Paras Chadha wrote: > +static int write_keyword_value(uint8_t **bytestream, const char * keyword, > int value) > +{ > +int len, ret; > +uint8_t * header = * bytestream; > +len = strlen(keyword); > + > +memcpy(header, keyword, len); > +memset(header + l

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Paras Chadha
On Sun, Jul 16, 2017 at 6:29 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/16/2017 1:31 PM, Paras Chadha wrote: > > Signed-off-by: Paras Chadha > > --- > > doc/general.texi | 2 + > > libavcodec/Makefile| 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/fi

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Nicolas George
L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : > Why is there no decoder? Because the decoder is in a separate patch, and the demuxer in yet another. And none of them can proceed until Paras Chadha starts deciding what is considered part of the codec and what is considered part of the

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 1:31 PM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > doc/general.texi | 2 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/fitsenc.c | 238 > + > libavformat/img2enc.c | 1 +

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Paras Chadha
On Sat, Jul 15, 2017 at 12:13 PM, Reimar Döffinger wrote: > On 14.07.2017, at 19:04, Paras Chadha wrote: > > > +if (bitpix == 16) { > > +for (j = 0; j < avctx->width; j++) { > > +bytestream2_put_be16(&pbc, AV_RB16(ptr) - bzero); > > +

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-14 Thread Reimar Döffinger
On 14.07.2017, at 19:04, Paras Chadha wrote: > +static int write_keyword_value(char * header, const char * keyword, int > value) > +{ > +int i, len, ret; > +len = strlen(keyword); > +for (i = 0; i < len; i++) { > +header[i] = keyword[i]; > +} would suggest memcpy (especi