Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-29 Thread David Bryant
On 7/28/19 10:27 AM, Paul B Mahol wrote: > On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote: > >> On 7/24/19 12:26 AM, Paul B Mahol wrote: >>> On 7/23/19, David Bryant wrote: On 7/23/19 12:47 AM, Paul B Mahol wrote: > On 7/23/19, David Bryant wrote: >> On 7/21/19 11:23 PM, Paul B

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote: > On 7/24/19 12:26 AM, Paul B Mahol wrote: > > On 7/23/19, David Bryant wrote: > >> On 7/23/19 12:47 AM, Paul B Mahol wrote: > >>> On 7/23/19, David Bryant wrote: > On 7/21/19 11:23 PM, Paul B Mahol wrote: > > On 7/22/19, David Bryant

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 7:18 PM Paul B Mahol wrote: > > > On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote: > >> On 7/24/19 12:26 AM, Paul B Mahol wrote: >> > On 7/23/19, David Bryant wrote: >> >> On 7/23/19 12:47 AM, Paul B Mahol wrote: >> >>> On 7/23/19, David Bryant wrote: >> On 7/21

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-28 Thread Paul B Mahol
On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote: > On 7/24/19 12:26 AM, Paul B Mahol wrote: > > On 7/23/19, David Bryant wrote: > >> On 7/23/19 12:47 AM, Paul B Mahol wrote: > >>> On 7/23/19, David Bryant wrote: > On 7/21/19 11:23 PM, Paul B Mahol wrote: > > On 7/22/19, David Bryant

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-27 Thread David Bryant
On 7/24/19 12:26 AM, Paul B Mahol wrote: > On 7/23/19, David Bryant wrote: >> On 7/23/19 12:47 AM, Paul B Mahol wrote: >>> On 7/23/19, David Bryant wrote: On 7/21/19 11:23 PM, Paul B Mahol wrote: > On 7/22/19, David Bryant wrote: >> Hi, >> >> As I promised late last year, he

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-27 Thread David Bryant
On 7/25/19 8:36 AM, Lynne wrote: > Jul 25, 2019, 6:12 AM by da...@wavpack.com: > +    crc += (crc << 1) + code; >>> Don't NIH CRCs, we have av_crc in lavu. See below how to use it. >>> >> It's not a standard crc, but more of a recirculating checksum, so the NIH >> code is required. >

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-25 Thread Lynne
Jul 25, 2019, 6:12 AM by da...@wavpack.com: >>> +    crc += (crc << 1) + code; >>> >> Don't NIH CRCs, we have av_crc in lavu. See below how to use it. >> > > It's not a standard crc, but more of a recirculating checksum, so the NIH > code is required. > Could you not call it a CRC then? "che

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-24 Thread Paul B Mahol
Hi. Until my comments are resolved, this should not get applied. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-24 Thread David Bryant
On 7/21/19 5:57 PM, Lynne wrote: > Jul 22, 2019, 12:03 AM by da...@wavpack.com: > >> Hi, >> >> As I promised late last year, here is a patch to add a WavPack DSD decoder. >> >> Thanks! >> >> -David Bryant >> >> +    unsigned char probabilities [MAX_HISTORY_BINS] [256]; >> +    unsigned char *value_

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-24 Thread Paul B Mahol
On 7/23/19, David Bryant wrote: > On 7/23/19 12:47 AM, Paul B Mahol wrote: >> On 7/23/19, David Bryant wrote: >>> On 7/21/19 11:23 PM, Paul B Mahol wrote: On 7/22/19, David Bryant wrote: > Hi, > > As I promised late last year, here is a patch to add a WavPack DSD > decoder.

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-23 Thread David Bryant
On 7/23/19 12:47 AM, Paul B Mahol wrote: > On 7/23/19, David Bryant wrote: >> On 7/21/19 11:23 PM, Paul B Mahol wrote: >>> On 7/22/19, David Bryant wrote: Hi, As I promised late last year, here is a patch to add a WavPack DSD decoder. Thanks! -David Bryant

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-23 Thread Paul B Mahol
On 7/23/19, David Bryant wrote: > On 7/21/19 11:23 PM, Paul B Mahol wrote: >> On 7/22/19, David Bryant wrote: >>> Hi, >>> >>> As I promised late last year, here is a patch to add a WavPack DSD >>> decoder. >>> >>> Thanks! >>> >>> -David Bryant >>> >>> >> Please correct me if I'm wrong, but why th

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-22 Thread David Bryant
On 7/21/19 11:23 PM, Paul B Mahol wrote: > On 7/22/19, David Bryant wrote: >> Hi, >> >> As I promised late last year, here is a patch to add a WavPack DSD decoder. >> >> Thanks! >> >> -David Bryant >> >> > Please correct me if I'm wrong, but why this uses new codec id? > Apparently is also copies

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread Paul B Mahol
On 7/22/19, David Bryant wrote: > Hi, > > As I promised late last year, here is a patch to add a WavPack DSD decoder. > > Thanks! > > -David Bryant > > Please correct me if I'm wrong, but why this uses new codec id? Apparently is also copies some logic from other files. __

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread Andreas Rheinhardt
Lynne: > Jul 22, 2019, 12:03 AM by da...@wavpack.com: >> +    for (p0 = 0; p0 < history_bins; ++p0) { >> +    int32_t sum_values; >> +    unsigned char *vp; >> + >> +    for (sum_values = i = 0; i < 256; ++i) >> +    s->summed_probabilities [p0] [i] = sum_values += >> s->probab

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread Lynne
Jul 22, 2019, 12:03 AM by da...@wavpack.com: > Hi, > > As I promised late last year, here is a patch to add a WavPack DSD decoder. > > Thanks! > > -David Bryant > > +    unsigned char probabilities [MAX_HISTORY_BINS] [256]; > +    unsigned char *value_lookup [MAX_HISTORY_BINS]; Use uint8_t throu

[FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread David Bryant
Hi, As I promised late last year, here is a patch to add a WavPack DSD decoder. Thanks! -David Bryant From d80f4fb59e4afec1e2c539391a7b4484f5ae8436 Mon Sep 17 00:00:00 2001 From: David Bryant Date: Sun, 21 Jul 2019 15:43:25 -0700 Subject: [PATCH] avcodec: add a WavPack DSD decoder Signed-off-