> can you add a fate test for this ?
I took a look around the existing tests to see how the existing extradata
parsing is being tested, but didn't find anything. Is there something existing
that I'm not seeing? If not, could you provide a little more guidance on how
you'd like this tested? Sinc
On Wed, Nov 01, 2017 at 05:49:48PM +, Breeden, Joshua wrote:
> > No but I wonder if the variables "y" and "t" can have more useful names
> > (that may or may not make the comment unneeded),
>
> I've made the variable names more self-explanatory and condensed the comments
>
> > Please do not r
> No but I wonder if the variables "y" and "t" can have more useful names
> (that may or may not make the comment unneeded),
I've made the variable names more self-explanatory and condensed the comments
> Please do not remove the empty line.
And fixed this as well.
Thanks,
Joshua BreedenFrom 6
2017-11-01 16:18 GMT+01:00 Breeden, Joshua :
>> Your patches contain a lot of trailing whitespace (afaict...)
>> that cannot be committed to our repository, please remove it.
>
> Thanks for pointing this out. I've attached new patches to fix this problem.
> patcheck complains about my non-doxy com
> Your patches contain a lot of trailing whitespace (afaict...)
> that cannot be committed to our repository, please remove it.
Thanks for pointing this out. I've attached new patches to fix this problem.
patcheck complains about my non-doxy comments, and about possible unused
variables. Variabl
2017-10-31 19:53 GMT+01:00 Breeden, Joshua :
> Hello,
>
> First patch submission... hopefully I do all of this correctly.?
Your patches contain a lot of trailing whitespace (afaict...)
that cannot be committed to our repository, please remove it.
To find it you can use the script "tools/patcheck"
Hello,
First patch submission... hopefully I do all of this correctly.?
Added basic support for H264 Annex G (Scalable Video Coding) to RTP module.
Implement splitting of PACSI NAL units (type 30).
Used existing H264 SPS decoder to parse Subset SPS NAL units (type 15) in h264
extradata.
As a
