On Wed, Jan 23, 2019 at 3:31 AM Uoti Urpala wrote:
>
> On Tue, 2019-01-22 at 15:35 -0300, James Almer wrote:
> > I'm not against renaming it to AV_ROUNDED_RSHIFT or similar, but other
> > than an entry in APIChanges we have no way to let library users that
> > RSHIFT will be removed two or so year
On Tue, 2019-01-22 at 15:35 -0300, James Almer wrote:
> I'm not against renaming it to AV_ROUNDED_RSHIFT or similar, but other
> than an entry in APIChanges we have no way to let library users that
> RSHIFT will be removed two or so years from now.
How about:
static inline void __attribute__ ((de
On 1/22/2019 2:17 PM, Vittorio Giovara wrote:
> On Mon, Jan 21, 2019 at 2:15 PM FeRD wrote:
>
>> On Mon, Jan 21, 2019 at 1:55 PM Moritz Barsnick wrote:
>>
>>> On Mon, Jan 21, 2019 at 12:38:58 -0500, FeRD (Frank Dana) wrote:
>>>
After applying both patches, 'make fate' succeeds and ffmpeg is
On Mon, Jan 21, 2019 at 2:15 PM FeRD wrote:
> On Mon, Jan 21, 2019 at 1:55 PM Moritz Barsnick wrote:
>
> > On Mon, Jan 21, 2019 at 12:38:58 -0500, FeRD (Frank Dana) wrote:
> >
> > > After applying both patches, 'make fate' succeeds and ffmpeg is still
> > > functional.
> >
> > You're not allowed
On Mon, Jan 21, 2019 at 1:55 PM Moritz Barsnick wrote:
> On Mon, Jan 21, 2019 at 12:38:58 -0500, FeRD (Frank Dana) wrote:
>
> > After applying both patches, 'make fate' succeeds and ffmpeg is still
> > functional.
>
> You're not allowed to break fate (or compilation). So the two pathes
> need to
On Mon, Jan 21, 2019 at 12:38:58 -0500, FeRD (Frank Dana) wrote:
> After applying both patches, 'make fate' succeeds and ffmpeg is still
> functional.
You're not allowed to break fate (or compilation). So the two pathes
need to be merged.
If, OTOH, the libraries are to be considered independent,
Patches to follow:
[PATCH 1/2] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT
[PATCH 2/2] avcodec: Change uses of RSHIFT to ROUNDED_RSHIFT
This is my first patch submission to ffmpeg (and at a tense
moment, it seems, but soldiering on...), please bear with me.
The RSHIFT macro in libavutil/common