Re: [FFmpeg-devel] Get rid of magic number in dsicinvideo.c

2015-11-23 Thread Clément Bœsch
On Tue, Nov 24, 2015 at 02:34:58AM +1100, Mohammad G wrote: > Greetings, > > File of interest is: libavcodec/dsicinvideo.c > > Line 103: > memcpy(huff_code_table, src, 15); > > Magic number 15 triggers some source code analysis tools to detect it as a > potential issue. > > I'm requesting a cha

Re: [FFmpeg-devel] Get rid of magic number in dsicinvideo.c

2015-11-23 Thread Ganesh Ajjanagadde
On Mon, Nov 23, 2015 at 10:34 AM, Mohammad G wrote: > Greetings, > > File of interest is: libavcodec/dsicinvideo.c > > Line 103: > memcpy(huff_code_table, src, 15); > > Magic number 15 triggers some source code analysis tools to detect it as a > potential issue. > > I'm requesting a change to: > m

[FFmpeg-devel] Get rid of magic number in dsicinvideo.c

2015-11-23 Thread Mohammad G
Greetings, File of interest is: libavcodec/dsicinvideo.c Line 103: memcpy(huff_code_table, src, 15); Magic number 15 triggers some source code analysis tools to detect it as a potential issue. I'm requesting a change to: memcpy(huff_code_table, src, sizeof(huff_code_table)); Which is equivalen