On Tue, Nov 24, 2015 at 02:34:58AM +1100, Mohammad G wrote: > Greetings, > > File of interest is: libavcodec/dsicinvideo.c > > Line 103: > memcpy(huff_code_table, src, 15); > > Magic number 15 triggers some source code analysis tools to detect it as a > potential issue. > > I'm requesting a change to: > memcpy(huff_code_table, src, sizeof(huff_code_table)); > > Which is equivalent in functionality. >
Since this won't change a thing unless i'm mistaken, it's strange that the static analyzer is complaining. isn't the problem about the fact that it's reading 15 bytes from a source buffer from which we don't check the length? > Regards, > Mohammad > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
