Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-29 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 04:30:27AM +, Donny Yang wrote: > On 29 March 2015 at 03:15, Michael Niedermayer wrote: > > > you can try AVCodecContext->frame_number, if that doesnt work > > you need to keep track of if you already had received a frame > > > I've tried both, but it turns out that AV

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-28 Thread Donny Yang
On 29 March 2015 at 03:15, Michael Niedermayer wrote: > you can try AVCodecContext->frame_number, if that doesnt work > you need to keep track of if you already had received a frame > I've tried both, but it turns out that AVCodecContext->frame_number seems to be thread-specific. That is, it star

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-28 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 03:14:20PM +, Donny Yang wrote: > > On 29 March 2015 at 00:08, Michael Niedermayer wrote: > > git send-email should send one patch per mail > Okay, here's my try with that > > > pts == 0 is not a reliable way to detect the first picture > What would be the recommende

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-28 Thread Donny Yang
On 29 March 2015 at 00:08, Michael Niedermayer wrote: > git send-email should send one patch per mail Okay, here's my try with that > pts == 0 is not a reliable way to detect the first picture What would be the recommended way, then? > this patchset also breaks PAL8 Yes, I know. The only reason

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-28 Thread Michael Niedermayer
On Sat, Mar 28, 2015 at 09:12:10AM +, Donny Yang wrote: > Sorry for the delay. I was a bit busy this week. > > On 25 March 2015 at 09:59, Michael Niedermayer wrote: > > > is there any advantage for multiple small IDATs ? > > if not i suggest to make the IDAT change to png as well in a sepera

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-28 Thread Donny Yang
Sorry for the delay. I was a bit busy this week. On 25 March 2015 at 09:59, Michael Niedermayer wrote: > is there any advantage for multiple small IDATs ? > if not i suggest to make the IDAT change to png as well in a seperate > patch so that a single frame APNG and PNG produce identical data >

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-27 Thread Paul B Mahol
On 3/24/15, Donny Yang wrote: > On 24 March 2015 at 10:45, Michael Niedermayer wrote: > >> the code already buffers the first frame and writes it in the >> trailer function so by the time the frame is actually written its >> known if its a single frame or multi frame file and the single frame >>

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-24 Thread Michael Niedermayer
On Tue, Mar 24, 2015 at 09:54:07PM +, Donny Yang wrote: > On 25 March 2015 at 04:18, Michael Niedermayer wrote: > > > the generated png files seem to differ > > > > ./ffmpeg -i lena.pnm ref.png > > > > -rw-r- 1 michael michael 180438 Mar 24 18:11 after-patches.png > > -rw-r- 1 michael

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-24 Thread Donny Yang
On 25 March 2015 at 04:18, Michael Niedermayer wrote: > the generated png files seem to differ > > ./ffmpeg -i lena.pnm ref.png > > -rw-r- 1 michael michael 180438 Mar 24 18:11 after-patches.png > -rw-r- 1 michael michael 180987 Mar 24 18:14 before-patches.png > It's because the non-APNG

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-24 Thread Michael Niedermayer
On Tue, Mar 24, 2015 at 02:17:29PM +, Donny Yang wrote: > On 24 March 2015 at 10:45, Michael Niedermayer wrote: > > > the code already buffers the first frame and writes it in the > > trailer function so by the time the frame is actually written its > > known if its a single frame or multi fr

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-24 Thread Donny Yang
On 24 March 2015 at 10:45, Michael Niedermayer wrote: > the code already buffers the first frame and writes it in the > trailer function so by the time the frame is actually written its > known if its a single frame or multi frame file and the single frame > case could use syntax identical to PNG

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2015 at 11:02:21PM +, Donny Yang wrote: > On 24 March 2015 at 01:18, Michael Niedermayer wrote: > > > Either way, changes to libavcodec and libavformat should be in 2 > > seperate patches > > > Okay, I've attached the separated patches. > > > > and your code changes output t

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-23 Thread Donny Yang
On 24 March 2015 at 01:18, Michael Niedermayer wrote: > Either way, changes to libavcodec and libavformat should be in 2 > seperate patches > Okay, I've attached the separated patches. > and your code changes output to normal .png files, that is every > whatever.png is now a apng file, iam not

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-23 Thread Michael Niedermayer
On Mon, Mar 23, 2015 at 10:50:17AM +, Donny Yang wrote: > Hello > > I was told to send my patch to ffmpeg-devel as well, so here it is. > Please comment/critique on it and how I should improve the patch. Theres another student working on this qualification task already, each student should id

Re: [FFmpeg-devel] Fwd: GSoC: APNG

2015-03-23 Thread Donny Yang
On 23 March 2015 at 21:50, Donny Yang wrote: > Hello > > I was told to send my patch to ffmpeg-devel as well, so here it is. > Please comment/critique on it and how I should improve the patch. > > Regards, > Donny > > -- Forwarded message -- > From: Donny Yang > Date: 22 March 20

[FFmpeg-devel] Fwd: GSoC: APNG

2015-03-23 Thread Donny Yang
Hello I was told to send my patch to ffmpeg-devel as well, so here it is. Please comment/critique on it and how I should improve the patch. Regards, Donny -- Forwarded message -- From: Donny Yang Date: 22 March 2015 at 01:10 Subject: GSoC: APNG To: one...@gmail.com Hello I'm