On Mon, Mar 23, 2015 at 10:50:17AM +0000, Donny Yang wrote: > Hello > > I was told to send my patch to ffmpeg-devel as well, so here it is. > Please comment/critique on it and how I should improve the patch.
Theres another student working on this qualification task already, each student should ideally work on a seperate qualification task also you arent listed in the list of qualification tasks: http://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2015-Qualis its a bit unfortunate situation as you already did most of the work so iam not completely sure what best to do now Either way, changes to libavcodec and libavformat should be in 2 seperate patches and your code changes output to normal .png files, that is every whatever.png is now a apng file, iam not sure this is what the user expects / wants [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
