Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-28 Thread Michael Niedermayer
On Sun, Mar 27, 2016 at 04:41:49PM -0400, Aaron Boxer wrote: > On Sun, Mar 27, 2016 at 4:10 PM, Michael Niedermayer > wrote: > > > On Thu, Mar 24, 2016 at 03:03:01PM +, Carl Eugen Hoyos wrote: > > > Aaron Boxer gmail.com> writes: > > > > > > > Anyways, the important thing here is to ensure t

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-27 Thread Aaron Boxer
On Sun, Mar 27, 2016 at 4:10 PM, Michael Niedermayer wrote: > On Thu, Mar 24, 2016 at 03:03:01PM +, Carl Eugen Hoyos wrote: > > Aaron Boxer gmail.com> writes: > > > > > Anyways, the important thing here is to ensure that > > > code from other projects gets proper attribution. > > > > Then pl

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-27 Thread Michael Niedermayer
On Thu, Mar 24, 2016 at 03:03:01PM +, Carl Eugen Hoyos wrote: > Aaron Boxer gmail.com> writes: > > > Anyways, the important thing here is to ensure that > > code from other projects gets proper attribution. > > Then please send a patch that adds the attribution, > remember that it is based

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Carl Eugen Hoyos
Aaron Boxer gmail.com> writes: > Anyways, the important thing here is to ensure that > code from other projects gets proper attribution. Then please send a patch that adds the attribution, remember that it is based on old libopenjpeg code, Reimar already provided an appropriate line. > I'm s

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Alex Beregszaszi
On Thu, Mar 24, 2016 at 2:44 PM, Aaron Boxer wrote: > On Thu, Mar 24, 2016 at 12:55 AM, Reimar Döffinger > wrote: > >> On Wed, Mar 23, 2016 at 10:50:06PM -0400, Aaron Boxer wrote: >> > On Wed, Mar 23, 2016 at 9:48 PM, Ricardo Constantino >> > wrote: >> > >> > > On 23 March 2016 at 22:35, Aaron Bo

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Aaron Boxer
Hi Alex, On Thu, Mar 24, 2016 at 10:49 AM, Alex Beregszaszi wrote: > On Thu, Mar 24, 2016 at 2:44 PM, Aaron Boxer wrote: > > On Thu, Mar 24, 2016 at 12:55 AM, Reimar Döffinger < > reimar.doeffin...@gmx.de > >> wrote: > > > >> On Wed, Mar 23, 2016 at 10:50:06PM -0400, Aaron Boxer wrote: > >> > O

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Aaron Boxer
On Thu, Mar 24, 2016 at 12:55 AM, Reimar Döffinger wrote: > On Wed, Mar 23, 2016 at 10:50:06PM -0400, Aaron Boxer wrote: > > On Wed, Mar 23, 2016 at 9:48 PM, Ricardo Constantino > > wrote: > > > > > On 23 March 2016 at 22:35, Aaron Boxer wrote: > > > > Back to my original point, what is the rea

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Aaron Boxer
On Thu, Mar 24, 2016 at 8:23 AM, Alex Beregszaszi wrote: > On Wed, Mar 23, 2016 at 10:35 PM, Aaron Boxer wrote: > > > On Wed, Mar 23, 2016 at 3:59 PM, Michael Bradshaw > > wrote: > > > > > On Wed, Mar 23, 2016 at 12:24 PM, Aaron Boxer > wrote: > > > > Hello Again, > > > > > > > > I took a look

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Michael Niedermayer
On Wed, Mar 23, 2016 at 06:35:20PM -0400, Aaron Boxer wrote: > On Wed, Mar 23, 2016 at 3:59 PM, Michael Bradshaw wrote: > > > On Wed, Mar 23, 2016 at 12:24 PM, Aaron Boxer wrote: > > > Hello Again, > > > > > > I took a look at the FFmpeg j2k code. Now, I've worked with OpenJPEG for > > > many ye

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Alex Beregszaszi
On Thu, Mar 24, 2016 at 12:23 PM, Alex Beregszaszi wrote: > > Not having seen the specification I do have a question: Is it possible this > code piece is in the spec? Many specs contain sample code or a description > leading to very similar implementations. > > I think this is important to double

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-24 Thread Alex Beregszaszi
On Wed, Mar 23, 2016 at 10:35 PM, Aaron Boxer wrote: > On Wed, Mar 23, 2016 at 3:59 PM, Michael Bradshaw > wrote: > > > On Wed, Mar 23, 2016 at 12:24 PM, Aaron Boxer wrote: > > > Hello Again, > > > > > > I took a look at the FFmpeg j2k code. Now, I've worked with OpenJPEG > for > > > many years

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Reimar Döffinger
On Wed, Mar 23, 2016 at 10:50:06PM -0400, Aaron Boxer wrote: > On Wed, Mar 23, 2016 at 9:48 PM, Ricardo Constantino > wrote: > > > On 23 March 2016 at 22:35, Aaron Boxer wrote: > > > Back to my original point, what is the reasoning not to just switch to > > > OpenJPEG? > > Both OpenJPEG 1 and 2

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Reimar Döffinger
On Wed, Mar 23, 2016 at 06:35:20PM -0400, Aaron Boxer wrote: > On Wed, Mar 23, 2016 at 3:59 PM, Michael Bradshaw wrote: > > > On Wed, Mar 23, 2016 at 12:24 PM, Aaron Boxer wrote: > > > Hello Again, > > > > > > I took a look at the FFmpeg j2k code. Now, I've worked with OpenJPEG for > > > many ye

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Aaron Boxer
On Wed, Mar 23, 2016 at 9:48 PM, Ricardo Constantino wrote: > On 23 March 2016 at 22:35, Aaron Boxer wrote: > > Back to my original point, what is the reasoning not to just switch to > > OpenJPEG? > Both OpenJPEG 1 and 2 are supported to add as external libraries in > FFmpeg. What do you mean by

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Ricardo Constantino
On 23 March 2016 at 22:35, Aaron Boxer wrote: > Back to my original point, what is the reasoning not to just switch to > OpenJPEG? Both OpenJPEG 1 and 2 are supported to add as external libraries in FFmpeg. What do you mean by switching to OpenJPEG? ___

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Aaron Boxer
On Wed, Mar 23, 2016 at 3:59 PM, Michael Bradshaw wrote: > On Wed, Mar 23, 2016 at 12:24 PM, Aaron Boxer wrote: > > Hello Again, > > > > I took a look at the FFmpeg j2k code. Now, I've worked with OpenJPEG for > > many years, and I would say at least 20% of the code in FFmpeg was either > > dire

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Rostislav Pehlivanov
On 23 March 2016 at 21:22, Carl Eugen Hoyos wrote: > Reimar Döffinger gmx.de> writes: > > > If it is copied the authors will hopefully admit to it > > (and hopefully be more careful about attribution in the > > future). > > I of course agree with what you wrote but the original > author of the j

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Carl Eugen Hoyos
Reimar Döffinger gmx.de> writes: > If it is copied the authors will hopefully admit to it > (and hopefully be more careful about attribution in the > future). I of course agree with what you wrote but the original author of the jpeg 2000 codec was unreachable a few weeks after he had submitt

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Reimar Döffinger
On Wed, Mar 23, 2016 at 03:24:47PM -0400, Aaron Boxer wrote: > Hello Again, > > I took a look at the FFmpeg j2k code. Now, I've worked with OpenJPEG for > many years, and I would say at least 20% of the code in FFmpeg was either > directly copied from OpenJPEG, or is very similar to OpenJPEG code.

Re: [FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Michael Bradshaw
On Wed, Mar 23, 2016 at 12:24 PM, Aaron Boxer wrote: > Hello Again, > > I took a look at the FFmpeg j2k code. Now, I've worked with OpenJPEG for > many years, and I would say at least 20% of the code in FFmpeg was either > directly copied from OpenJPEG, or is very similar to OpenJPEG code. > > I t

[FFmpeg-devel] FFmpeg code Attribution

2016-03-23 Thread Aaron Boxer
Hello Again, I took a look at the FFmpeg j2k code. Now, I've worked with OpenJPEG for many years, and I would say at least 20% of the code in FFmpeg was either directly copied from OpenJPEG, or is very similar to OpenJPEG code. I think the people who did the work on the FFmpeg codec would readily