Re: [FFmpeg-devel] Added support for XV video files

2019-03-26 Thread Michael Niedermayer
On Mon, Mar 25, 2019 at 04:19:37PM +0530, Shivam Goyal wrote: > > On 3/25/19 3:59 PM, Michael Niedermayer wrote: > >On Sun, Mar 24, 2019 at 04:35:40PM +0530, Shivam Goyal wrote: > >>The attached patch is for ticket #3720 > >> > >>     https://trac.ffmpeg.org/ticket/3720 > >> > >>I have tested this

Re: [FFmpeg-devel] Added support for XV video files

2019-03-25 Thread Shivam Goyal
On 3/25/19 3:59 PM, Michael Niedermayer wrote: On Sun, Mar 24, 2019 at 04:35:40PM +0530, Shivam Goyal wrote: The attached patch is for ticket #3720     https://trac.ffmpeg.org/ticket/3720 I have tested this demuxer on the files 1.xv and 5.xv attached with the ticket http://samples.ffmpeg.or

Re: [FFmpeg-devel] Added support for XV video files

2019-03-25 Thread Michael Niedermayer
On Sun, Mar 24, 2019 at 04:35:40PM +0530, Shivam Goyal wrote: > The attached patch is for ticket #3720 > >     https://trac.ffmpeg.org/ticket/3720 > > I have tested this demuxer on the files 1.xv and 5.xv attached with the > ticket > > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3720/ > >

Re: [FFmpeg-devel] Added support for XV video files

2019-03-25 Thread Moritz Barsnick
On Mon, Mar 25, 2019 at 07:57:04 +0530, Shivam Goyal wrote: > which would be intialised at the time of reading header) whenever we > need to read from the input file, Which would recquire more processing > and would make the program slow for both xv  and flv files Good point. I agree that decidin

Re: [FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Shivam Goyal
On 3/25/19 4:47 AM, Moritz Barsnick wrote: On Sun, Mar 24, 2019 at 13:39:09 +0100, Moritz Barsnick wrote: Another thing: On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote: libavformat/xvdec.c | 1395 ++ libavformat/xvtools.h| 95 +++

Re: [FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Shivam Goyal
On 3/24/19 6:09 PM, Moritz Barsnick wrote: On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote: libavformat/xvdec.c | 1395 ++ libavformat/xvtools.h| 95 +++ This looks like a 90% copy of flvdec, with some modifications. I believe it shou

Re: [FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Moritz Barsnick
On Sun, Mar 24, 2019 at 13:39:09 +0100, Moritz Barsnick wrote: Another thing: > On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote: > > libavformat/xvdec.c | 1395 ++ > > libavformat/xvtools.h| 95 +++ You shouldn't put actual code in header

Re: [FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Moritz Barsnick
On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote: > libavformat/xvdec.c | 1395 ++ > libavformat/xvtools.h| 95 +++ This looks like a 90% copy of flvdec, with some modifications. I believe it should be merged into flvdec as an additional sup

[FFmpeg-devel] Added support for XV video files

2019-03-24 Thread Shivam Goyal
The attached patch is for ticket #3720     https://trac.ffmpeg.org/ticket/3720 I have tested this demuxer on the files 1.xv and 5.xv attached with the ticket http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3720/  It is working on both of these files. As XV video files are flv files with s