On Sun, Mar 24, 2019 at 13:39:09 +0100, Moritz Barsnick wrote: Another thing:
> On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote: > > libavformat/xvdec.c | 1395 ++++++++++++++++++++++++++++++++++++++ > > libavformat/xvtools.h | 95 +++ You shouldn't put actual code in header files, that's really bad style. If you need complementary functions, they should be defined in e.g. xvtools.c and declared in xvtools.h. Moritz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
