On 12/28/2015 04:58 PM, Ganesh Ajjanagadde wrote:
@Mats: this is a good example for why it is very helpful to reduce the
volume of email messages, and to think over them before sending to
avoid small additions/removals/clarifications.
Yes, i can fully understand that. I'm going to behave in t
On Mon, Dec 28, 2015 at 6:39 AM, Nicolas George wrote:
> L'octidi 8 nivôse, an CCXXIV, Michael Niedermayer a écrit :
>> for reference: (similar code prior to the patches)
>
> Indeed. Mats already pointed one of them. This would warrant some
> refactoring. At the very least:
>
> ff_frame_new_pa
On 12/28/2015 04:41 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Well, I guess I have to temper myself a bit. But I don't accept that someone
else grabs the honor for something I've written. Would you, once again? Can
you understand my point whatsoever?
I hav
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> Well, I guess I have to temper myself a bit. But I don't accept that someone
> else grabs the honor for something I've written. Would you, once again? Can
> you understand my point whatsoever?
I have seen your point. I had already seen your p
On 12/28/2015 04:33 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
So it's OK for him to say he wrote the significant parts of the patch?
It's ok for him to say that, it's ok for other people to disagree and prove
their point.
It's not ok to rehash the questio
On 12/28/2015 04:27 PM, Mats Peterson wrote:
On 12/28/2015 04:26 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Listen, Nicolas. I'm not DENOUNCING Carl Eugen by saying he didn't
write the
significant parts of the patch. Where did you get that from? Would
YOU li
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> So it's OK for him to say he wrote the significant parts of the patch?
It's ok for him to say that, it's ok for other people to disagree and prove
their point.
It's not ok to rehash the question endlessly.
It's not ok to dig up irrelevant h
On 12/28/2015 04:26 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Listen, Nicolas. I'm not DENOUNCING Carl Eugen by saying he didn't write the
significant parts of the patch. Where did you get that from? Would YOU like
someone else grabbing the honor for somethi
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> Listen, Nicolas. I'm not DENOUNCING Carl Eugen by saying he didn't write the
> significant parts of the patch. Where did you get that from? Would YOU like
> someone else grabbing the honor for something you've written? I don't think
> you woul
On 12/28/2015 04:04 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
The point is to make people understand he didn't write "significant parts"
of the latest patch. I want to make that clear. Not that I care who wrote
it, as long as it works. I just don't like his
On 12/28/2015 04:07 PM, Mats Peterson wrote:
On 12/28/2015 04:04 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
The point is to make people understand he didn't write "significant
parts"
of the latest patch. I want to make that clear. Not that I care who
wrote
i
On 12/28/2015 04:04 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
The point is to make people understand he didn't write "significant parts"
of the latest patch. I want to make that clear. Not that I care who wrote
it, as long as it works. I just don't like his
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> The point is to make people understand he didn't write "significant parts"
> of the latest patch. I want to make that clear. Not that I care who wrote
> it, as long as it works. I just don't like his grabbing the honor for
> something he didn'
On 12/28/2015 03:48 PM, Mats Peterson wrote:
On 12/28/2015 03:45 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
By the way, here's a clip from the old patch (THIS one had
significant parts
written by Carl alright) that got rave reviews from Hendrik Leppkes,
call
On 12/28/2015 03:45 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
By the way, here's a clip from the old patch (THIS one had significant parts
written by Carl alright) that got rave reviews from Hendrik Leppkes, calling
it "an extremely ugly hack", complaining a
On 12/28/2015 03:39 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Michael Niedermayer a écrit :
for reference: (similar code prior to the patches)
Indeed. Mats already pointed one of them. This would warrant some
refactoring. At the very least:
ff_frame_new_palette(frame, palet
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> By the way, here's a clip from the old patch (THIS one had significant parts
> written by Carl alright) that got rave reviews from Hendrik Leppkes, calling
> it "an extremely ugly hack", complaining at the calling into another demuxer
> (by us
On 12/28/2015 03:32 PM, Mats Peterson wrote:
On 12/28/2015 03:29 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 12:07:38PM +0100, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Michael, he's talking about the OLD patch that was never applied. My
patch
has b
L'octidi 8 nivôse, an CCXXIV, Michael Niedermayer a écrit :
> for reference: (similar code prior to the patches)
Indeed. Mats already pointed one of them. This would warrant some
refactoring. At the very least:
ff_frame_new_palette(frame, palette);
Then Ganesh will be able to add av_warn_unu
On 12/28/2015 03:29 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 12:07:38PM +0100, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Michael, he's talking about the OLD patch that was never applied. My patch
has been written from scratch, more or less. I did
On Mon, Dec 28, 2015 at 12:07:38PM +0100, Nicolas George wrote:
> L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> > Michael, he's talking about the OLD patch that was never applied. My patch
> > has been written from scratch, more or less. I did borrowed some palette
> > loops from mov.c, b
On 12/28/2015 02:45 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
I'm afraid he won't agree on ANYTHING I say, after my initial treatment of
him on the bug tracker. I have excused myself for that as well, but he's
slow to forget...
Maybe if you stopped ADDING
On 12/28/2015 02:39 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 02:18:14PM +0100, Mats Peterson wrote:
On 12/28/2015 02:16 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 02:09:54PM +0100, Mats Peterson wrote:
On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
On Mon, Dec 28
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> I'm afraid he won't agree on ANYTHING I say, after my initial treatment of
> him on the bug tracker. I have excused myself for that as well, but he's
> slow to forget...
Maybe if you stopped ADDING insults like that, it would start making thi
On 12/28/2015 02:39 PM, Michael Niedermayer wrote:
1AM +0100, Mats Peterson wrote:
I'm afraid he won't agree on ANYTHING I say, after my initial treatment
of him on the bug tracker. I have excused myself for that as well, but
he's slow to forget...
Mats
--
Mats Peterson
http://matsp888.no-
On Mon, Dec 28, 2015 at 02:18:14PM +0100, Mats Peterson wrote:
> On 12/28/2015 02:16 PM, Michael Niedermayer wrote:
> >On Mon, Dec 28, 2015 at 02:09:54PM +0100, Mats Peterson wrote:
> >>On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
> >>>On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson w
On 12/28/2015 02:18 PM, Mats Peterson wrote:
On 12/28/2015 02:16 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 02:09:54PM +0100, Mats Peterson wrote:
On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson wrote:
On 12/28/2015 10:34
On 12/28/2015 02:16 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 02:09:54PM +0100, Mats Peterson wrote:
On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson wrote:
On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
On Mon, Dec 28
On Mon, Dec 28, 2015 at 02:09:54PM +0100, Mats Peterson wrote:
> On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
> >On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson wrote:
> >>On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
> >>>On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyo
On 12/28/2015 02:09 PM, Mats Peterson wrote:
On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson wrote:
On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyos wrote:
Michael Niedermay
On 12/28/2015 02:03 PM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson wrote:
On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyos wrote:
Michael Niedermayer niedermayer.cc> writes:
Patch splited in
On Mon, Dec 28, 2015 at 11:46:21AM +0100, Mats Peterson wrote:
> On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
> >On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyos wrote:
> >>Michael Niedermayer niedermayer.cc> writes:
> >>
> >>>Patch splited in move and matroska part
> >>>i removed
On 12/28/2015 12:25 PM, Mats Peterson wrote:
On 12/28/2015 12:21 PM, Mats Peterson wrote:
On 12/28/2015 12:07 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Michael, he's talking about the OLD patch that was never applied. My
patch
has been written from scratch
On 12/28/2015 12:21 PM, Mats Peterson wrote:
On 12/28/2015 12:07 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Michael, he's talking about the OLD patch that was never applied. My
patch
has been written from scratch, more or less. I did borrowed some palette
lo
On 12/28/2015 12:07 PM, Nicolas George wrote:
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
Michael, he's talking about the OLD patch that was never applied. My patch
has been written from scratch, more or less. I did borrowed some palette
loops from mov.c, but I have also attributed the
L'octidi 8 nivôse, an CCXXIV, Mats Peterson a écrit :
> Michael, he's talking about the OLD patch that was never applied. My patch
> has been written from scratch, more or less. I did borrowed some palette
> loops from mov.c, but I have also attributed the previous authors at the top
> of qtpalette
On 12/28/2015 11:46 AM, Mats Peterson wrote:
On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyos wrote:
Michael Niedermayer niedermayer.cc> writes:
Patch splited in move and matroska part
i removed this memcpy() for now from what i
co
On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyos wrote:
Michael Niedermayer niedermayer.cc> writes:
Patch splited in move and matroska part
i removed this memcpy() for now from what i
commited as there is clearly no consenus on it
On 12/28/2015 10:34 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyos wrote:
Michael Niedermayer niedermayer.cc> writes:
Patch splited in move and matroska part
i removed this memcpy() for now from what i
commited as there is clearly no consenus on it
On Mon, Dec 28, 2015 at 03:10:18AM +, Carl Eugen Hoyos wrote:
> Michael Niedermayer niedermayer.cc> writes:
>
> > Patch splited in move and matroska part
> > i removed this memcpy() for now from what i
> > commited as there is clearly no consenus on it
>
> I would really have appreciated a
On 12/28/2015 04:10 AM, Carl Eugen Hoyos wrote:
Michael Niedermayer niedermayer.cc> writes:
Patch splited in move and matroska part
i removed this memcpy() for now from what i
commited as there is clearly no consenus on it
I would really have appreciated a real review:
Apart from the unrelat
On 12/28/2015 03:16 AM, Michael Niedermayer wrote:
this is true but iam not sure if this is really "just" a mplayer
issue.
If there is a global palette, then it is not unreasonable that it
is placed in a stream global place. This is especially true if not
all packets are copied and the palette f
On 12/28/2015 04:12 AM, Mats Peterson wrote:
On 12/28/2015 04:10 AM, Carl Eugen Hoyos wrote:
Michael Niedermayer niedermayer.cc> writes:
Patch splited in move and matroska part
i removed this memcpy() for now from what i
commited as there is clearly no consenus on it
I would really have app
On 12/28/2015 04:10 AM, Carl Eugen Hoyos wrote:
Michael Niedermayer niedermayer.cc> writes:
Patch splited in move and matroska part
i removed this memcpy() for now from what i
commited as there is clearly no consenus on it
I would really have appreciated a real review:
Apart from the unrelat
Michael Niedermayer niedermayer.cc> writes:
> Patch splited in move and matroska part
> i removed this memcpy() for now from what i
> commited as there is clearly no consenus on it
I would really have appreciated a real review:
Apart from the unrelated audio fix a significant
part of the patch
On 12/28/2015 03:27 AM, Mats Peterson wrote:
On 12/28/2015 03:21 AM, Mats Peterson wrote:
On 12/28/2015 03:16 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote:
Mats Peterson ffmpeg.org> writes:
+memcpy(st->codec->extradata, matroska->pa
On 12/28/2015 03:21 AM, Mats Peterson wrote:
On 12/28/2015 03:16 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote:
Mats Peterson ffmpeg.org> writes:
+memcpy(st->codec->extradata, matroska->palette,
+AVPALETTE_SIZE);
On 12/28/2015 03:16 AM, Michael Niedermayer wrote:
On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote:
Mats Peterson ffmpeg.org> writes:
+memcpy(st->codec->extradata, matroska->palette,
+AVPALETTE_SIZE);
As said, please remove this,
you must not f
On Mon, Dec 28, 2015 at 12:24:10AM +, Carl Eugen Hoyos wrote:
> Mats Peterson ffmpeg.org> writes:
>
> > +memcpy(st->codec->extradata, matroska->palette,
> > +AVPALETTE_SIZE);
>
> As said, please remove this,
> you must not fix MPlayer
> issues in FFmpeg.
this is tr
On 12/28/2015 02:58 AM, Mats Peterson wrote:
On 12/28/2015 02:56 AM, Mats Peterson wrote:
On 12/28/2015 01:24 AM, Carl Eugen Hoyos wrote:
Mats Peterson ffmpeg.org> writes:
+memcpy(st->codec->extradata, matroska->palette,
+AVPALETTE_SIZE);
As said, please remove this
On 12/28/2015 02:56 AM, Mats Peterson wrote:
On 12/28/2015 01:24 AM, Carl Eugen Hoyos wrote:
Mats Peterson ffmpeg.org> writes:
+memcpy(st->codec->extradata, matroska->palette,
+AVPALETTE_SIZE);
As said, please remove this, you must not fix MPlayer
issues in FFmpeg.
(
On 12/28/2015 01:24 AM, Carl Eugen Hoyos wrote:
Mats Peterson ffmpeg.org> writes:
+memcpy(st->codec->extradata, matroska->palette,
+AVPALETTE_SIZE);
As said, please remove this, you must not fix MPlayer
issues in FFmpeg.
(The issue in MPlayer does not exist but that d
Mats Peterson ffmpeg.org> writes:
> +memcpy(st->codec->extradata, matroska->palette,
> +AVPALETTE_SIZE);
As said, please remove this, you must not fix MPlayer
issues in FFmpeg.
(The issue in MPlayer does not exist but that doesn't
matter on this mailing list.)
Carl Eug
Removed the 'stsd' variable from ff_get_qtpalette() in qtpalette.c.
Updated the doxy documentation for ff_get_qtpalette() accordingly.
Description of patch follows:
Palettized QuickTime video in Matroska has hitherto not been recognized
whatsoever, and the "palette" used has been completely rand
54 matches
Mail list logo
