On Mon, Dec 28, 2015 at 12:24:10AM +0000, Carl Eugen Hoyos wrote: > Mats Peterson <matsp888-at-yahoo.com <at> ffmpeg.org> writes: > > > + memcpy(st->codec->extradata, matroska->palette, > > + AVPALETTE_SIZE); >
> As said, please remove this, > you must not fix MPlayer > issues in FFmpeg. this is true but iam not sure if this is really "just" a mplayer issue. If there is a global palette, then it is not unreasonable that it is placed in a stream global place. This is especially true if not all packets are copied and the palette from the first packet is lost as a result. either way, the commit message for this part just points at mplayer, which isnt really good for a description of a "bug fix" in libavformat Patch splited in move and matroska part i removed this memcpy() for now from what i commited as there is clearly no consenus on it > (The issue in MPlayer does not exist but that doesn't > matter on this mailing list.) > > Carl Eugen > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fault, turn to yourself and study your own failings. Then you will forget your anger. -- Epictetus
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
