Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 10:06 PM James Almer wrote: > On 1/25/2021 11:15 AM, Nuo Mi wrote: > > @@ -1637,6 +2047,16 @@ static const SEIMessageTypeDescriptor > cbs_sei_h265_types[] = { > > SEI_MESSAGE_TYPE_END > > }; > > > > +static const SEIMessageTypeDescriptor cbs_sei_h266_types[] = { >

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread James Almer
On 1/25/2021 11:15 AM, Nuo Mi wrote: @@ -1637,6 +2047,16 @@ static const SEIMessageTypeDescriptor cbs_sei_h265_types[] = { SEI_MESSAGE_TYPE_END }; +static const SEIMessageTypeDescriptor cbs_sei_h266_types[] = { You forgot to use this in ff_cbs_sei_find_type() below. Otherwise it wi

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 9:40 PM James Almer wrote: > On 1/26/2021 10:35 AM, Nuo Mi wrote: > > On Tue, Jan 26, 2021 at 5:54 AM James Almer wrote: > > > >> On 1/25/2021 2:12 PM, James Almer wrote: > >>> Did you add this just to set active_vps? I thought the > >>> idea was to remove all that since

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread James Almer
On 1/26/2021 10:35 AM, Nuo Mi wrote: On Tue, Jan 26, 2021 at 5:54 AM James Almer wrote: On 1/25/2021 2:12 PM, James Almer wrote: Did you add this just to set active_vps? I thought the idea was to remove all that since it's not a concept defined in h266. The following should get rid of activ

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 5:54 AM James Almer wrote: > On 1/25/2021 2:12 PM, James Almer wrote: > > Did you add this just to set active_vps? I thought the > > idea was to remove all that since it's not a concept defined in h266. > > The following should get rid of active_*, but the actual fields ca

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-26 Thread Nuo Mi
On Tue, Jan 26, 2021 at 2:35 AM James Almer wrote: > On 1/25/2021 2:12 PM, James Almer wrote: > > On 1/25/2021 11:15 AM, Nuo Mi wrote: > >> +static int FUNC(ref_pic_list_struct)(CodedBitstreamContext *ctx, > >> RWContext *rw, > >> + H266RefPicListStruct *curren

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-25 Thread James Almer
On 1/25/2021 2:12 PM, James Almer wrote: Did you add this just to set active_vps? I thought the idea was to remove all that since it's not a concept defined in h266. The following should get rid of active_*, but the actual fields can't be removed from CodedBitstreamH266Context unless we duplic

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-25 Thread James Almer
On 1/25/2021 2:12 PM, James Almer wrote: On 1/25/2021 11:15 AM, Nuo Mi wrote: +static int FUNC(ref_pic_list_struct)(CodedBitstreamContext *ctx, RWContext *rw, + H266RefPicListStruct *current, + uint8_t list_idx, uint8_t rpl

Re: [FFmpeg-devel] [PATCH v4 4/9] avcodec: add cbs for h266/vvc

2021-01-25 Thread James Almer
On 1/25/2021 11:15 AM, Nuo Mi wrote: +static int FUNC(ref_pic_list_struct)(CodedBitstreamContext *ctx, RWContext *rw, + H266RefPicListStruct *current, + uint8_t list_idx, uint8_t rpls_idx, +