On Tue, Jan 26, 2021 at 9:40 PM James Almer <jamr...@gmail.com> wrote:
> On 1/26/2021 10:35 AM, Nuo Mi wrote: > > On Tue, Jan 26, 2021 at 5:54 AM James Almer <jamr...@gmail.com> wrote: > > > >> On 1/25/2021 2:12 PM, James Almer wrote: > >>> Did you add this just to set active_vps? I thought the > >>> idea was to remove all that since it's not a concept defined in h266. > >> > >> The following should get rid of active_*, but the actual fields can't be > >> removed from CodedBitstreamH266Context unless we duplicate the > >> cbs_h2645_replace_ps() macro to remove the relevant lines it shares with > >> the other two codecs. > >> > > One solution is define a cbs_h26n_replace_ps. > > cbs_h2645 _replace_ps calls cbs_h26n_replace_ps and set active_xps to > NULL. > > cbs_h266_replace_ps calls the cbs_h26n_replace_ps only. > > I did not use this since I think active_xps will make the caller's life > > easier. > > They do not need to use the id again and again to get pps, sps, vps. > > If you think remove it is better, I can remove it. > > I'll leave that decision to Mark. I know he tries to keep CBS as close > as the spec as possible, which is why i assumed removing active_*ps for > h266 felt like the proper thing to do. > Sure. Let us wait for Mark's decision. thanks for the suggestion and patch anyway. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
