L'octidi 28 messidor, an CCXXIII, Michael Niedermayer a écrit :
> i think its best if the author, Vesselin Bontchev decides if he
> prefers to initialize them or not as it seems theres no consensus
> what is better
Yes, of course. This exchange was just a discussion of principles.
Regards,
--
On Thu, Jul 16, 2015 at 08:31:45PM +0200, Nicolas George wrote:
> L'octidi 28 messidor, an CCXXIII, wm4 a écrit :
> > You dislike robust code?
>
> This is not robust, this is defensive. I despise defensive programming.
i think its best if the author, Vesselin Bontchev decides if he
prefers to ini
L'octidi 28 messidor, an CCXXIII, wm4 a écrit :
> You dislike robust code?
This is not robust, this is defensive. I despise defensive programming.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mai
On Thu, 16 Jul 2015 14:48:05 +0200
Nicolas George wrote:
> L'octidi 28 messidor, an CCXXIII, wm4 a écrit :
> > Even if there's a bug, initializing them will at least make the
> > behavior predictable and reproducible, instead of random,
> > platform-dependent, and sporadic.
>
> Which is exactly
L'octidi 28 messidor, an CCXXIII, wm4 a écrit :
> Even if there's a bug, initializing them will at least make the
> behavior predictable and reproducible, instead of random,
> platform-dependent, and sporadic.
Which is exactly the problem: instead of a very visible problem, you get a
subtly-wrong
On Thu, 16 Jul 2015 13:59:44 +0200
Nicolas George wrote:
> L'octidi 28 messidor, an CCXXIII, wm4 a écrit :
> > Initializing them is always safer. Valgrind doesn't catch everything
> > either.
>
> Initializing them may hide bugs and delay their detection and fixing.
Even if there's a bug, initia
L'octidi 28 messidor, an CCXXIII, wm4 a écrit :
> Initializing them is always safer. Valgrind doesn't catch everything
> either.
Initializing them may hide bugs and delay their detection and fixing.
Regards,
--
Nicolas George
___
ffmpeg-devel mailin
On Wed, 15 Jul 2015 23:03:07 +0200
Nicolas George wrote:
> > +
> > +#define DRM_BLOB_SIZE 56
> > +
> > +static int mov_read_adrm(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> > +{
> > +// extracted from libAAX_SDK.so and AAXSDKWin.dll files!
> > +unsigned char fixed_key[] = { 0x77, 0x2
Vesselin Bontchev yandex.com> writes:
> +ffio_read_size(pb, output, 8); // go to
> offset 8, absolute postion 0x251
Sorry if I misunderstand the code, but I believe
this should be "avio_skip()"
> +ffio_read_size(pb, input, DRM_BLOB_SIZE);
Is there a disadvantage using avio_read()?
>
Hi Carl, Hendrik,
I would like to get this patch merged in FFmpeg. Is there something I can do to
make this happen?
Thanks again,
Vesselin
14.07.2015, 01:17, "Vesselin Bontchev" :
> Thanks for all the feedback, and help.
>
> Vesselin
___
ffmpeg-devel
Le sextidi 26 messidor, an CCXXIII, Vesselin Bontchev a écrit :
> Thanks for all the feedback, and help.
A few more comments, sorry.
> From 1ed235454a61fe1f8d993d09d3d6398e7609c624 Mon Sep 17 00:00:00 2001
> From: Vesselin Bontchev
> Date: Sat, 11 Jul 2015 18:02:47 +
> Subject: [PATCH] Add s
Dana 15. 7. 2015. 22:38 osoba "Vesselin Bontchev" <
vesselin.bontc...@yandex.com> napisala je:
>
> Hi Carl, Hendrik,
>
> I would like to get this patch merged in FFmpeg. Is there something I can
do to make this happen?
>
Sorry for my ignorance but are there samples this can be tested?
> Thanks ag
Thanks for all the feedback, and help.
VesselinFrom 1ed235454a61fe1f8d993d09d3d6398e7609c624 Mon Sep 17 00:00:00 2001
From: Vesselin Bontchev
Date: Sat, 11 Jul 2015 18:02:47 +
Subject: [PATCH] Add support for Audible AAX (and AAX+) files
---
libavformat/isom.h |5 ++
libavformat/mov.c
13 matches
Mail list logo
