2017-01-31 14:06 GMT+01:00 Matteo Naccari :
> Re: On removal of malloc, free, etc. I think this v4 takes care of this as
> the commit messages says.
I don't think so.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/m
> That's pretty old by now. Can you send a v4 patch set?
Sorry my bad, I've already sent a v4 on the 14/12. Do you want me to rebase the
patch to the latest commit on the branch master?
Re: On removal of malloc, free, etc. I think this v4 takes care of this as the
commit messages says.
2017-01-31 13:52 GMT+01:00 Carl Eugen Hoyos :
> 2017-01-31 13:42 GMT+01:00 Matteo Naccari :
>> Any news on the integration of the patch identified in the subject line?
>
> So far, you haven't removed the calls to malloc().
> Please use av_freep() (instead of av_free) to free the memory.
And pleas
2017-01-31 13:42 GMT+01:00 Matteo Naccari :
> Hello everyone,
>
> Any news on the integration of the patch identified in the subject line?
So far, you haven't removed the calls to malloc().
Please use av_freep() (instead of av_free) to free the memory.
Carl Eugen
_
On Tue, 31 Jan 2017 12:42:54 +
Matteo Naccari wrote:
> Hello everyone,
>
> Any news on the integration of the patch identified in the subject line?
>
> Best regards,
> Matteo
That's pretty old by now. Can you send a v4 patch set?
___
ffmpeg-devel
Hello everyone,
Any news on the integration of the patch identified in the subject line?
Best regards,
Matteo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > It has. It points to the position in the options buffer which is going to be
> filled with the command line being parsed. So it's not redundant.
>
> Then what does buffer_filled do?
It keeps track on the number of characters written in the options buffer so
far. I appreciate this could have
On Wed, Dec 14, 2016 at 14:23:05 +, Matteo Naccari wrote:
> Ok, point taken on the av_* functions. On the handling bit, I was
> thinking to flag the error via av_log and then call exit_program(1),
> after, of course, having released the memory allocated up to that
> point. Would that be ok?
C
On Wed, 14 Dec 2016 14:23:05 +
Matteo Naccari wrote:
> > Missing error handling, and maybe overflow handling. Also, we don't use
> > malloc/realloc/free, but av_malloc/av_realloc/av_free. I'm not sure why we
> > do this (it doesn't have much of a justification for realloc at least), but
> >
On Wed, Dec 14, 2016 at 3:23 PM, Matteo Naccari
wrote:
>> Missing error handling, and maybe overflow handling. Also, we don't use
>> malloc/realloc/free, but av_malloc/av_realloc/av_free. I'm not sure why we
>> do this (it doesn't have much of a justification for realloc at least), but
>> it's
>>
> Missing error handling, and maybe overflow handling. Also, we don't use
> malloc/realloc/free, but av_malloc/av_realloc/av_free. I'm not sure why we
> do this (it doesn't have much of a justification for realloc at least), but
> it's
> probably better to be consistent.
Ok, point taken on the av
On Tue, 6 Dec 2016 11:35:49 -0300
James Almer wrote:
> On 12/6/2016 11:03 AM, wm4 wrote:
> >> +static void add_option(const char* current_option, optionContext*
> >> option_ctx)
> >> +{
> >> +int option_length = strlen(current_option);
> >> +if (option_ctx->buffer_filled + option_length
On 12/6/2016 11:03 AM, wm4 wrote:
>> +static void add_option(const char* current_option, optionContext*
>> option_ctx)
>> +{
>> +int option_length = strlen(current_option);
>> +if (option_ctx->buffer_filled + option_length + 1 >
>> option_ctx->options_buffer_size) {
>> +option_ctx
On Thu, 1 Dec 2016 12:04:38 +
Matteo Naccari wrote:
> - This patch contains the changes to interface the Turing codec
> (http://turingcodec.org/) to ffmpeg. The patch was modified to address
> the comments in the review as follows:
> - Added a pkg-config file to list all dependencies r
- This patch contains the changes to interface the Turing codec
(http://turingcodec.org/) to ffmpeg. The patch was modified to address
the comments in the review as follows:
- Added a pkg-config file to list all dependencies required by
libturing. This should address the issue pointed out b
15 matches
Mail list logo
