> Missing error handling, and maybe overflow handling. Also, we don't use > malloc/realloc/free, but av_malloc/av_realloc/av_free. I'm not sure why we > do this (it doesn't have much of a justification for realloc at least), but > it's > probably better to be consistent.
Ok, point taken on the av_* functions. On the handling bit, I was thinking to flag the error via av_log and then call exit_program(1), after, of course, having released the memory allocated up to that point. Would that be ok? > > Does the "s" field have any purpose? It seems to be redundant with the > other fields. It has. It points to the position in the options buffer which is going to be filled with the command line being parsed. So it's not redundant. ----------------------------- http://www.bbc.co.uk This e-mail (and any attachments) is confidential and may contain personal views which are not the views of the BBC unless specifically stated. If you have received it in error, please delete it from your system. Do not use, copy or disclose the information in any way nor act in reliance on it and notify the sender immediately. Please note that the BBC monitors e-mails sent or received. Further communication will signify your consent to this. ----------------------------- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
