Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-29 Thread Kieran Kunhya
On Sun, 28 Jun 2020 at 15:27, Carl Eugen Hoyos wrote: > Am So., 28. Juni 2020 um 16:24 Uhr schrieb Gautam Ramakrishnan > : > > > Oh got it, just need to ignore the text then. > > You *can* > > Carl Eugen > Why are you confusing Gautam like this? If I were new to FFmpeg and working on this I woul

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-28 Thread Carl Eugen Hoyos
Am So., 28. Juni 2020 um 16:24 Uhr schrieb Gautam Ramakrishnan : > Oh got it, just need to ignore the text then. You *can* Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-28 Thread Gautam Ramakrishnan
On Sun, Jun 28, 2020 at 6:09 PM Nicolas George wrote: > > Gautam Ramakrishnan (12020-06-28): > > This is what I do not understand. Suppose the file does not start > > with the bytes "PG ML ", how is that to be handled? > > The same way as if it did. > > Take a valid PGX file. Replace these six oct

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-28 Thread Nicolas George
Gautam Ramakrishnan (12020-06-28): > This is what I do not understand. Suppose the file does not start > with the bytes "PG ML ", how is that to be handled? The same way as if it did. Take a valid PGX file. Replace these six octets with FOOBAR: why should it make any difference for your decoder?

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-28 Thread Gautam Ramakrishnan
On Sun, Jun 28, 2020 at 4:21 PM Nicolas George wrote: > > Gautam Ramakrishnan (12020-06-28): > > I shall change this. I do not understand how the check can be > > removed. It is compulsory that a PGX file must have these bytes > > In case it was not clear, I think Carl Eugen was suggesting you inc

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-28 Thread Nicolas George
Gautam Ramakrishnan (12020-06-28): > I shall change this. I do not understand how the check can be > removed. It is compulsory that a PGX file must have these bytes In case it was not clear, I think Carl Eugen was suggesting you include the string directly in the comparison. But you do not need t

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-28 Thread Gautam Ramakrishnan
On Sun, Jun 28, 2020 at 12:41 AM Carl Eugen Hoyos wrote: > > Am Sa., 27. Juni 2020 um 20:11 Uhr schrieb : > > > +static int ff_pgx_decode_header(AVCodecContext *avctx, PGXContext * s, > > +int *depth, int *width, int *height, > > +int

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-27 Thread Carl Eugen Hoyos
Am Sa., 27. Juni 2020 um 20:11 Uhr schrieb : > +static int ff_pgx_decode_header(AVCodecContext *avctx, PGXContext * s, > +int *depth, int *width, int *height, > +int *sign) > +{ > +const char *header_start = "PG ML "; > +int b

[FFmpeg-devel] [PATCH v2 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-27 Thread gautamramk
From: Gautam Ramakrishnan This patch adds a pgx decoder. --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/pgxdec.c | 199 ++