Re: [FFmpeg-devel] [PATCH v2 1/2] Move bitswap_32() into a header file.

2017-01-08 Thread Steinar H. Gunderson
On Sun, Jan 08, 2017 at 11:01:14AM -0300, James Almer wrote: > Disregard that part then. Just address the name of the function. Will do. Waiting with sending of a new patch to see if there are more comments coming that I can address in the same batch. /* Steinar */ -- Homepage: https://www.sesse

Re: [FFmpeg-devel] [PATCH v2 1/2] Move bitswap_32() into a header file.

2017-01-08 Thread James Almer
On 1/8/2017 10:55 AM, Steinar H. Gunderson wrote: > On Sun, Jan 08, 2017 at 10:52:52AM -0300, James Almer wrote: >> Also, when moving code in general we expect a patch that makes use of said >> code as part of a set. > > I don't understand. I send a patch where I both make the move and add a > new

Re: [FFmpeg-devel] [PATCH v2 1/2] Move bitswap_32() into a header file.

2017-01-08 Thread Steinar H. Gunderson
On Sun, Jan 08, 2017 at 10:52:52AM -0300, James Almer wrote: > Also, when moving code in general we expect a patch that makes use of said > code as part of a set. I don't understand. I send a patch where I both make the move and add a new use. Then I get told to split them into two separate patche

Re: [FFmpeg-devel] [PATCH v2 1/2] Move bitswap_32() into a header file.

2017-01-08 Thread James Almer
On 1/8/2017 10:14 AM, Steinar H. Gunderson wrote: > Allows more codecs than mpeg12video to make use of it. Rename to > av_bitswap_32() > because it's a public symbol now. mathops.h is not a public header. You can keep the bitswap_32() name or use ff_bitswap_32() instead. Also, when moving code i

[FFmpeg-devel] [PATCH v2 1/2] Move bitswap_32() into a header file.

2017-01-08 Thread Steinar H. Gunderson
Allows more codecs than mpeg12video to make use of it. Rename to av_bitswap_32() because it's a public symbol now. --- libavcodec/bitstream.c | 14 +++--- libavcodec/mathops.h | 8 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/bitstream.c b/libavco