Re: [FFmpeg-devel] [PATCH v2] [RFC] lavc, lavfmt: add FLIF decoding support

2020-08-03 Thread Kartik K. Khullar
Wow, That is such an awesome idea. Did not know about that offsetof() thing earlier. Definitely going to use this idea. > IIRC, the Linux kernel makes heavy use of this structure. > That's really cool. Actually I implemented linked lists and not dynamic arrays because some elements from somewhe

Re: [FFmpeg-devel] [PATCH v2] [RFC] lavc, lavfmt: add FLIF decoding support

2020-08-03 Thread Nicolas George
Kartik K. Khullar (12020-08-03): > > Mixing linked lists and indices is usually a sign you are doing > > something wrong. > > > > Here, I believe you would do better with a doubly linked list and > > pointers instead of indices. > > > > Note: there is a trick with doubly linked lists where you put

Re: [FFmpeg-devel] [PATCH v2] [RFC] lavc, lavfmt: add FLIF decoding support

2020-08-02 Thread Kartik K. Khullar
My apologies, I should have removed other parts of the quoted code which I was not replying to. The reply is unnecesarily long now. On Mon, 3 Aug, 2020, 12:39 am Kartik K. Khullar, wrote: > > > On Sun, Aug 2, 2020 at 5:57 PM Nicolas George wrote: > >> Anamitra Ghorui (12020-07-30): >> > Visible

Re: [FFmpeg-devel] [PATCH v2] [RFC] lavc, lavfmt: add FLIF decoding support

2020-08-02 Thread Anamitra Ghorui
Hello, Thanks a lot for the code review. We will make sure to correct all of these mistakes after we are done with all of the features in about a week, before we post our (supposed) final patch for the decoder. For some reason my mail client has truncated the indentation (and any series of multipl

Re: [FFmpeg-devel] [PATCH v2] [RFC] lavc, lavfmt: add FLIF decoding support

2020-08-02 Thread Nicolas George
Anamitra Ghorui (12020-08-02): > Thanks a lot for the code review. We will make sure to correct all of > these mistakes after we are done with all of the features in about a > week, before we post our (supposed) final patch for the decoder. Thanks. > For some reason my mail client has truncated t