Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Jun Li
On Mon, May 27, 2019 at 7:52 AM Nicolas George wrote: > Jun Li (12019-05-27): > > I compared the perf between vflip and this patch before, they take almost > > the same time, around 9ms for a frame. > > Hflip is a little special, but surely I can update the patch to avoid > frame > > copy, and it

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Nicolas George
Jun Li (12019-05-27): > I compared the perf between vflip and this patch before, they take almost > the same time, around 9ms for a frame. > Hflip is a little special, but surely I can update the patch to avoid frame > copy, and it will be as fast as hflip. > > But still this is duplicated feature

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Paul B Mahol
On 5/27/19, Jun Li wrote: > On Mon, May 27, 2019 at 1:39 AM Paul B Mahol wrote: > >> On 5/27/19, Jun Li wrote: >> > On Mon, May 27, 2019 at 12:32 AM Paul B Mahol wrote: >> > >> >> On 5/27/19, Jun Li wrote: >> >> > On Sun, May 26, 2019 at 2:09 AM Paul B Mahol >> wrote: >> >> > >> >> >> On 5/26

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Jun Li
On Mon, May 27, 2019 at 1:39 AM Paul B Mahol wrote: > On 5/27/19, Jun Li wrote: > > On Mon, May 27, 2019 at 12:32 AM Paul B Mahol wrote: > > > >> On 5/27/19, Jun Li wrote: > >> > On Sun, May 26, 2019 at 2:09 AM Paul B Mahol > wrote: > >> > > >> >> On 5/26/19, Jun Li wrote: > >> >> > On Sun,

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Paul B Mahol
On 5/27/19, Jun Li wrote: > On Mon, May 27, 2019 at 12:32 AM Paul B Mahol wrote: > >> On 5/27/19, Jun Li wrote: >> > On Sun, May 26, 2019 at 2:09 AM Paul B Mahol wrote: >> > >> >> On 5/26/19, Jun Li wrote: >> >> > On Sun, May 26, 2019 at 1:16 AM Paul B Mahol >> wrote: >> >> > >> >> >> On 5/25

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Jun Li
On Mon, May 27, 2019 at 12:32 AM Paul B Mahol wrote: > On 5/27/19, Jun Li wrote: > > On Sun, May 26, 2019 at 2:09 AM Paul B Mahol wrote: > > > >> On 5/26/19, Jun Li wrote: > >> > On Sun, May 26, 2019 at 1:16 AM Paul B Mahol > wrote: > >> > > >> >> On 5/25/19, Jun Li wrote: > >> >> > Add exif

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Paul B Mahol
On 5/27/19, Jun Li wrote: > On Sun, May 26, 2019 at 2:09 AM Paul B Mahol wrote: > >> On 5/26/19, Jun Li wrote: >> > On Sun, May 26, 2019 at 1:16 AM Paul B Mahol wrote: >> > >> >> On 5/25/19, Jun Li wrote: >> >> > Add exif orientation support and expose an option. >> >> > --- >> >> > libavfilt

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-26 Thread Jun Li
On Sun, May 26, 2019 at 2:09 AM Paul B Mahol wrote: > On 5/26/19, Jun Li wrote: > > On Sun, May 26, 2019 at 1:16 AM Paul B Mahol wrote: > > > >> On 5/25/19, Jun Li wrote: > >> > Add exif orientation support and expose an option. > >> > --- > >> > libavfilter/vf_transpose.c | 258 > +++

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-26 Thread Paul B Mahol
On 5/26/19, Jun Li wrote: > On Sun, May 26, 2019 at 1:16 AM Paul B Mahol wrote: > >> On 5/25/19, Jun Li wrote: >> > Add exif orientation support and expose an option. >> > --- >> > libavfilter/vf_transpose.c | 258 + >> > 1 file changed, 207 insertions(+), 51

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-26 Thread Jun Li
On Sun, May 26, 2019 at 1:16 AM Paul B Mahol wrote: > On 5/25/19, Jun Li wrote: > > Add exif orientation support and expose an option. > > --- > > libavfilter/vf_transpose.c | 258 + > > 1 file changed, 207 insertions(+), 51 deletions(-) > > > > diff --git a/

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-26 Thread Paul B Mahol
On 5/25/19, Jun Li wrote: > Add exif orientation support and expose an option. > --- > libavfilter/vf_transpose.c | 258 + > 1 file changed, 207 insertions(+), 51 deletions(-) > > diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c > index dd54

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-25 Thread Jun Li
On Sat, May 25, 2019 at 2:46 AM Nicolas George wrote: > Jun Li (12019-05-24): > > Add exif orientation support and expose an option. > > --- > > libavfilter/vf_transpose.c | 258 + > > 1 file changed, 207 insertions(+), 51 deletions(-) > > If I read the code c

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-25 Thread Nicolas George
Jun Li (12019-05-24): > Add exif orientation support and expose an option. > --- > libavfilter/vf_transpose.c | 258 + > 1 file changed, 207 insertions(+), 51 deletions(-) If I read the code correctly, when orientation=1 (unchanged), this code will copy the fra

[FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-24 Thread Jun Li
Add exif orientation support and expose an option. --- libavfilter/vf_transpose.c | 258 + 1 file changed, 207 insertions(+), 51 deletions(-) diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c index dd54947bd9..4aebfb9ee4 100644 --- a/libavfil