Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-20 Thread Aman Gupta
On Mon, Mar 12, 2018 at 9:25 AM, Mark Thompson wrote: > On 12/03/18 15:10, Hendrik Leppkes wrote: > > On Mon, Mar 12, 2018 at 2:38 PM, Mark Thompson wrote: > >> On 12/03/18 09:54, Hendrik Leppkes wrote: > >>> On Sun, Mar 11, 2018 at 7:30 PM, Mark Thompson wrote: > --- > libavcodec/h2

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Mark Thompson
On 12/03/18 15:10, Hendrik Leppkes wrote: > On Mon, Mar 12, 2018 at 2:38 PM, Mark Thompson wrote: >> On 12/03/18 09:54, Hendrik Leppkes wrote: >>> On Sun, Mar 11, 2018 at 7:30 PM, Mark Thompson wrote: --- libavcodec/h264_metadata_bsf.c | 121 ++

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Hendrik Leppkes
On Mon, Mar 12, 2018 at 2:38 PM, Mark Thompson wrote: > On 12/03/18 09:54, Hendrik Leppkes wrote: >> On Sun, Mar 11, 2018 at 7:30 PM, Mark Thompson wrote: >>> --- >>> libavcodec/h264_metadata_bsf.c | 121 >>> + >>> 1 file changed, 121 insertions(+) >>> >>

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Mark Thompson
On 12/03/18 09:54, Hendrik Leppkes wrote: > On Sun, Mar 11, 2018 at 7:30 PM, Mark Thompson wrote: >> --- >> libavcodec/h264_metadata_bsf.c | 121 >> + >> 1 file changed, 121 insertions(+) >> >> diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Mark Thompson
On 12/03/18 07:19, Aman Gupta wrote: > On Sun, Mar 11, 2018 at 11:30 AM, Mark Thompson wrote: > >> --- >> libavcodec/h264_metadata_bsf.c | 121 ++ >> +++ >> 1 file changed, 121 insertions(+) >> >> diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_m

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Devin Heitmueller
> Does extracting really make sense? Doesn't the data end up out of > order and basically unusable? For what it’s worth, I’ve got a video filter which extracts the A53 side data and saves it into an MCC file (Telestream MacCaption format). If people think that’s something that would be useful,

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Hendrik Leppkes
On Sun, Mar 11, 2018 at 7:30 PM, Mark Thompson wrote: > --- > libavcodec/h264_metadata_bsf.c | 121 > + > 1 file changed, 121 insertions(+) > > diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c > index 36047887ca..d340c55990 1006

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Aman Gupta
On Sun, Mar 11, 2018 at 11:30 AM, Mark Thompson wrote: > --- > libavcodec/h264_metadata_bsf.c | 121 ++ > +++ > 1 file changed, 121 insertions(+) > > diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_ > bsf.c > index 36047887ca..d340c55990

[FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-11 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 121 + 1 file changed, 121 insertions(+) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 36047887ca..d340c55990 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h264_metadat