I have sent a patch fixing the gapless playback . PTAL. Basically the patch
will make sure that , at least in case of one edit list for audio, the
timestamps provided by the demuxer are strictly monotonically increasing ,
and also that the skip_samples field is correctly set to the edit list
media
On Tue, 9 Aug 2016 18:48:22 -0700
Sasi Inguva wrote:
> diff --git a/tests/ref/fate/gaplessenc-itunes-to-ipod-aac
> b/tests/ref/fate/gaplessenc-itunes-to-ipod-aac
> index aacb058..145bd09 100644
> --- a/tests/ref/fate/gaplessenc-itunes-to-ipod-aac
> +++ b/tests/ref/fate/gaplessenc-itunes-to-ipo
On Sun, Sep 18, 2016 at 6:05 PM, Michael Niedermayer wrote:
> On Sun, Sep 18, 2016 at 02:45:52PM -0700, Sasi Inguva wrote:
> > Is it ok to just log an error and return 0 ?
>
> Is a global timescale of 0 allowed ?
> QT does not seem to explicitly say so
>
> can something better be done ?
>
> If yo
On Sun, Sep 18, 2016 at 02:45:52PM -0700, Sasi Inguva wrote:
> Is it ok to just log an error and return 0 ?
Is a global timescale of 0 allowed ?
QT does not seem to explicitly say so
can something better be done ?
If you are not sure what to do for the 0 case the best would likely be
to ask for
Is it ok to just log an error and return 0 ?
On Sep 18, 2016 1:53 PM, "Michael Niedermayer"
wrote:
> On Sat, Sep 17, 2016 at 03:14:24PM -0700, Sasi Inguva wrote:
> [...]
> > > [...]
> > > > @@ -2756,6 +2757,343 @@ static int mov_read_sbgp(MOVContext *c,
> > > AVIOContext *pb, MOVAtom atom)
> > >
On Sat, Sep 17, 2016 at 03:14:24PM -0700, Sasi Inguva wrote:
[...]
> > [...]
> > > @@ -2756,6 +2757,343 @@ static int mov_read_sbgp(MOVContext *c,
> > AVIOContext *pb, MOVAtom atom)
> > > return pb->eof_reached ? AVERROR_EOF : 0;
> > > }
> > >
> > > +/**
> > > + * Get ith edit list entry (med
On Thu, Sep 15, 2016 at 01:08:40PM -0700, Sasi Inguva wrote:
> On Wed, Sep 14, 2016 at 1:57 PM, Michael Niedermayer > wrote:
>
> > On Wed, Sep 14, 2016 at 12:20:52AM -0700, Sasi Inguva wrote:
> > > On Tue, Sep 13, 2016 at 4:39 PM, Sasi Inguva wrote:
> > >
> > > > Sorry for the very late reply. I
On Wed, Sep 14, 2016 at 12:20:52AM -0700, Sasi Inguva wrote:
> On Tue, Sep 13, 2016 at 4:39 PM, Sasi Inguva wrote:
>
> > Sorry for the very late reply. I was busy with other things.
> >
> > On Sat, Sep 3, 2016 at 4:48 PM, Michael Niedermayer <
> > mich...@niedermayer.cc> wrote:
> >
> >> On Sat, S
On Tue, Sep 13, 2016 at 4:39 PM, Sasi Inguva wrote:
> Sorry for the very late reply. I was busy with other things.
>
> On Sat, Sep 3, 2016 at 4:48 PM, Michael Niedermayer <
> mich...@niedermayer.cc> wrote:
>
>> On Sat, Sep 03, 2016 at 12:06:39PM -0700, Sasi Inguva wrote:
>> > Hi Michael,
>> >
>>
On Sat, Sep 03, 2016 at 12:06:39PM -0700, Sasi Inguva wrote:
> Hi Michael,
>
> In fact from audacity I see that out-ingu.wav out-mp3.wav are almost
> equivalent,
They do not match. (and that is alot more vissible if you scale the
time axis up a bit)
You also dont use the existing API for handlin
On Fri, Sep 02, 2016 at 01:00:59PM -0700, Sasi Inguva wrote:
> On Aug 31, 2016 5:23 AM, "Michael Niedermayer"
> wrote:
> >
> > On Tue, Aug 30, 2016 at 06:37:22PM -0700, Sasi Inguva wrote:
> > > On Sun, Aug 28, 2016 at 3:10 AM, Michael Niedermayer
> > > > wrote:
> > >
> > > > On Sat, Aug 27, 2016
On Fri, Sep 02, 2016 at 01:00:59PM -0700, Sasi Inguva wrote:
> On Aug 31, 2016 5:23 AM, "Michael Niedermayer"
> wrote:
> >
> > On Tue, Aug 30, 2016 at 06:37:22PM -0700, Sasi Inguva wrote:
> > > On Sun, Aug 28, 2016 at 3:10 AM, Michael Niedermayer
> > > > wrote:
[...]
> >
> >
> > > The timestamps
On Aug 31, 2016 5:23 AM, "Michael Niedermayer"
wrote:
>
> On Tue, Aug 30, 2016 at 06:37:22PM -0700, Sasi Inguva wrote:
> > On Sun, Aug 28, 2016 at 3:10 AM, Michael Niedermayer
> > wrote:
> >
> > > On Sat, Aug 27, 2016 at 03:30:24PM -0700, Sasi Inguva wrote:
> > > > On Fri, Aug 26, 2016 at 5:55 PM
On Tue, Aug 30, 2016 at 06:37:22PM -0700, Sasi Inguva wrote:
> On Sun, Aug 28, 2016 at 3:10 AM, Michael Niedermayer > wrote:
>
> > On Sat, Aug 27, 2016 at 03:30:24PM -0700, Sasi Inguva wrote:
> > > On Fri, Aug 26, 2016 at 5:55 PM, Michael Niedermayer
> > > > > wrote:
> > >
> > > > On Fri, Aug 26
On Sat, Aug 27, 2016 at 03:30:24PM -0700, Sasi Inguva wrote:
> On Fri, Aug 26, 2016 at 5:55 PM, Michael Niedermayer > wrote:
>
> > On Fri, Aug 26, 2016 at 12:49:19PM -0700, Sasi Inguva wrote:
> > > I think there is some bug in mp3 decoder which is making skip
> > > samples -1431655766 for ~/ticke
On Fri, Aug 26, 2016 at 5:55 PM, Michael Niedermayer wrote:
> On Fri, Aug 26, 2016 at 12:49:19PM -0700, Sasi Inguva wrote:
> > I think there is some bug in mp3 decoder which is making skip
> > samples -1431655766 for ~/tickets/5528/fire.mp3 . For now I have removed
> > the assert from the 3rd com
On Fri, Aug 26, 2016 at 12:49:19PM -0700, Sasi Inguva wrote:
> I think there is some bug in mp3 decoder which is making skip
> samples -1431655766 for ~/tickets/5528/fire.mp3 . For now I have removed
> the assert from the 3rd commit.
> For the file one.mov , I think the audio has edit list with sta
On Thu, Aug 25, 2016 at 12:31:19PM -0700, Sasi Inguva wrote:
> oops. thanks for pointing that out. Even in our version of ffmpeg, that
> assert doesn't get compiled so we never catched it. That assert logic is
> not correct anymore. At the end of one edit list there can be frames marked
> as discar
On Thu, Aug 25, 2016 at 12:31:19PM -0700, Sasi Inguva wrote:
> oops. thanks for pointing that out. Even in our version of ffmpeg, that
> assert doesn't get compiled so we never catched it. That assert logic is
> not correct anymore. At the end of one edit list there can be frames marked
> as discar
On Wed, Aug 24, 2016 at 06:42:16PM -0700, Sasi Inguva wrote:
> hmm. strange. I just rebased my branch on top of head, and reran the test,
> and it succeeds along with all other fate tests. I am attaching the 4
> patches again here.
you need to build with
--assert-level=2
to see the failure
[...]
On Mon, Aug 15, 2016 at 07:04:57PM -0700, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva
> ---
> libavformat/mov.c | 334 +++-
> tests/Makefile |1 +
> tests/fate/mov.mak | 28 +
> tests/ref/fate/
2016-08-24 16:44 GMT+02:00 Sasi Inguva :
> ping!
I will apply this if nobody objects.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
ping!
On Fri, Aug 19, 2016 at 9:49 AM, Sasi Inguva wrote:
> I don't know who the owner of MOV demuxer is. If somebody could do a
> deeper review of this patch and approve it that would be great.
>
> Thanks,
> Sasi
>
> On Wed, Aug 17, 2016 at 8:59 AM, Sasi Inguva wrote:
>
>> Thanks
>>
>> On Aug
I don't know who the owner of MOV demuxer is. If somebody could do a deeper
review of this patch and approve it that would be great.
Thanks,
Sasi
On Wed, Aug 17, 2016 at 8:59 AM, Sasi Inguva wrote:
> Thanks
>
> On Aug 17, 2016 6:25 AM, "Clément Bœsch" wrote:
>
>> On Mon, Aug 15, 2016 at 07:04:
Thanks
On Aug 17, 2016 6:25 AM, "Clément Bœsch" wrote:
> On Mon, Aug 15, 2016 at 07:04:56PM -0700, Sasi Inguva wrote:
> > Changes done. Also commented in the code about the differences between
> the add_index_entry function and teh ff_add_index_entry function.
> >
> > About stream copy, yes ther
On Mon, Aug 15, 2016 at 07:04:56PM -0700, Sasi Inguva wrote:
> Changes done. Also commented in the code about the differences between the
> add_index_entry function and teh ff_add_index_entry function.
>
> About stream copy, yes there will be a big behavior difference when doing "-c
> copy" for
Changes done. Also commented in the code about the differences between the
add_index_entry function and teh ff_add_index_entry function.
About stream copy, yes there will be a big behavior difference when doing "-c
copy" for files with edit lists.
Currently, ignoring edit lists we will copy all
On Wed, Aug 10, 2016 at 07:35:00PM -0700, Sasi Inguva wrote:
[...]
> +/**
> + * Get ith edit list entry (media time, duration).
> + */
> +static int get_edit_list_entry(MOVStreamContext *msc,
msc should be marked as const
> + unsigned int edit_list_index,
> +
Hi!
2016-08-10 19:14 GMT+02:00 Sasi Inguva :
> Oops. I forgot to git add the new test ref files. Please find attached, the
> modified patch. Will also send it through git send-email.
Please also fix the "%lld" occurrences: There is %"PRId64"
Carl Eugen
___
On Tue, Aug 09, 2016 at 06:48:22PM -0700, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva
> ---
> libavformat/mov.c| 323 -
> tests/Makefile |1 +
> tests/fate/mov.mak | 28 +
> tests/ref/fate/filte
Signed-off-by: Sasi Inguva
---
libavformat/mov.c| 323 -
tests/Makefile |1 +
tests/fate/mov.mak | 28 +
tests/ref/fate/filter-fps-cfr|1 -
tests/ref/fate/gaplessenc-itunes-to-ip
31 matches
Mail list logo
