On Thu, Aug 25, 2016 at 12:31:19PM -0700, Sasi Inguva wrote: > oops. thanks for pointing that out. Even in our version of ffmpeg, that > assert doesn't get compiled so we never catched it. That assert logic is > not correct anymore. At the end of one edit list there can be frames marked > as discard, for which we would keep increasing the timestamp even if they > are marked as discard, so that when the timestamps are rerodered to compute > PTS B-frames get the correct PTS. But the next edit list should always > start with the timestamp of the last-non-discarded frame of the previous > edit list. Hence we will get non-increasing timestamps added as index > entries. > > The test may have passed for you before, because before that line was > assert(..) instead of av_assert1(...) so maybe that line wasn't getting > compiled before. Attaching the 4 patches again.
patchset breaks timestamps for audio: ./ffmpeg -i matrixbench_mpeg2.mpg -t 0.1 one.mov ./ffprobe -show_packets -print_format compact one.mov packet|codec_type=video|stream_index=0|pts=0|pts_time=0.000000|dts=-1024|dts_time=-0.080000|duration=512|duration_time=0.040000|convergence_duration=N/A|convergence_duration_time=N/A|size=9368|pos=36|flags=K packet|codec_type=video|stream_index=0|pts=1024|pts_time=0.080000|dts=-512|dts_time=-0.040000|duration=512|duration_time=0.040000|convergence_duration=N/A|convergence_duration_time=N/A|size=2190|pos=9404|flags=_ packet|codec_type=audio|stream_index=1|pts=0|pts_time=0.000000|dts=0|dts_time=0.000000|duration=N/A|duration_time=N/A|convergence_duration=N/A|convergence_duration_time=N/A|size=323|pos=11594|flags=K packet|codec_type=video|stream_index=0|pts=512|pts_time=0.040000|dts=0|dts_time=0.000000|duration=512|duration_time=0.040000|convergence_duration=N/A|convergence_duration_time=N/A|size=1328|pos=11894|flags=_ packet|codec_type=audio|stream_index=1|pts=0|pts_time=0.000000|dts=0|dts_time=0.000000|duration=1024|duration_time=0.021333|convergence_duration=N/A|convergence_duration_time=N/A|size=261|pos=13222|flags=K if you look at the audio stream 2 packets have the same pts, that looks wrong, previously the first packet had -1024 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
