Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: disable openGOP by default

2019-12-30 Thread James Almer
On 12/30/2019 9:39 PM, Derek Buitenhuis wrote: > On 30/12/2019 23:50, James Almer wrote: >> No, it doesn't. The libx264 wrapper disables openGOP by default (by >> doing the same thing as this patch). Or at least it does now. No idea >> back then. > > It seems to have gone back and forth over the y

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: disable openGOP by default

2019-12-30 Thread Derek Buitenhuis
On 30/12/2019 23:50, James Almer wrote: > No, it doesn't. The libx264 wrapper disables openGOP by default (by > doing the same thing as this patch). Or at least it does now. No idea > back then. It seems to have gone back and forth over the years... > My objective is having both encoder wrappers

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: disable openGOP by default

2019-12-30 Thread James Almer
On 12/30/2019 8:04 PM, Derek Buitenhuis wrote: > On 30/12/2019 19:20, James Almer wrote: >> This is in line with the behavior of libx264. >> >> Signed-off-by: James Almer >> --- >> libavcodec/libx265.c | 1 + >> 1 file changed, 1 insertion(+) > > How does this square with 841c1efc78ace70497187d9

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: disable openGOP by default

2019-12-30 Thread Derek Buitenhuis
On 30/12/2019 19:20, James Almer wrote: > This is in line with the behavior of libx264. > > Signed-off-by: James Almer > --- > libavcodec/libx265.c | 1 + > 1 file changed, 1 insertion(+) How does this square with 841c1efc78ace70497187d984adf31c7cc2cd7b6? During review for that commit, the reas

[FFmpeg-devel] [PATCH 4/4] avcodec/libx265: disable openGOP by default

2019-12-30 Thread James Almer
This is in line with the behavior of libx264. Signed-off-by: James Almer --- libavcodec/libx265.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index a97bf19e91..7049a3144a 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -671,6 +6