On 12/30/2019 8:04 PM, Derek Buitenhuis wrote: > On 30/12/2019 19:20, James Almer wrote: >> This is in line with the behavior of libx264. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> libavcodec/libx265.c | 1 + >> 1 file changed, 1 insertion(+) > > How does this square with 841c1efc78ace70497187d984adf31c7cc2cd7b6? During > review for that commit, the reason given for allowing it[0] was that libx264 > had > the same default.
No, it doesn't. The libx264 wrapper disables openGOP by default (by doing the same thing as this patch). Or at least it does now. No idea back then. My objective is having both encoder wrappers behave as similar as possible (Sort of like vpx and aom). If i for example wanted to set strict GOPs for a dash scenario with fixed segment durations, with libx264 i only need to set keyint_min and keyint_max to some value using the global options, but with libx265 I'd have to do that and also disable openGOP. I can drop this patch if you'd rather keep the default from the library. > > - Derek > > [0] Thread (see replies, including your own): > http://ffmpeg.org/pipermail/ffmpeg-devel/2018-June/230843.html > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
