Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-15 Thread Lukasz Marek
On 15.11.2014 19:59, Michael Niedermayer wrote: On Sat, Nov 15, 2014 at 02:32:26AM +0100, Lukasz Marek wrote: On 15.11.2014 01:24, Michael Niedermayer wrote: +/** + * String containing paris of key and values describing recommended encoder configuration. + * Paris are separated by

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-15 Thread Lukasz Marek
On 15.11.2014 19:59, Michael Niedermayer wrote: On Sat, Nov 15, 2014 at 02:32:26AM +0100, Lukasz Marek wrote: On 15.11.2014 01:24, Michael Niedermayer wrote: +/** + * String containing paris of key and values describing recommended encoder configuration. + * Paris are separated by

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-15 Thread Michael Niedermayer
On Sat, Nov 15, 2014 at 02:32:26AM +0100, Lukasz Marek wrote: > On 15.11.2014 01:24, Michael Niedermayer wrote: > +/** > + * String containing paris of key and values describing recommended > encoder configuration. > + * Paris are separated by ','. > + * Keys ar

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-14 Thread Lukasz Marek
On 15.11.2014 01:24, Michael Niedermayer wrote: +/** + * String containing paris of key and values describing recommended encoder configuration. + * Paris are separated by ','. + * Keys are separated from values by '='. + */ +char *recommended_encoder_configuration; thi

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-14 Thread Michael Niedermayer
On Fri, Nov 14, 2014 at 11:33:08PM +0100, Lukasz Marek wrote: > On 12.11.2014 02:12, Michael Niedermayer wrote: > >On Tue, Nov 11, 2014 at 11:59:32PM +0100, Lukasz Marek wrote: > >>On 11.11.2014 14:46, Michael Niedermayer wrote: > >>>the muxer might run in a seperate thread from the encoder, priv_d

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-14 Thread Lukasz Marek
On 12.11.2014 02:12, Michael Niedermayer wrote: On Tue, Nov 11, 2014 at 11:59:32PM +0100, Lukasz Marek wrote: On 11.11.2014 14:46, Michael Niedermayer wrote: the muxer might run in a seperate thread from the encoder, priv_data could change while its being accessed, iam not sure if that would ca

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-13 Thread Lukasz Marek
On 13 November 2014 01:42, Michael Niedermayer wrote: > On Thu, Nov 13, 2014 at 01:04:28AM +0100, Lukasz Marek wrote: > > On 12.11.2014 20:32, Michael Niedermayer wrote: > > >On Wed, Nov 12, 2014 at 06:31:52PM +0100, Lukasz Marek wrote: > > >>On 12 November 2014 17:53, Michael Niedermayer > wrot

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Michael Niedermayer
On Thu, Nov 13, 2014 at 01:04:28AM +0100, Lukasz Marek wrote: > On 12.11.2014 20:32, Michael Niedermayer wrote: > >On Wed, Nov 12, 2014 at 06:31:52PM +0100, Lukasz Marek wrote: > >>On 12 November 2014 17:53, Michael Niedermayer wrote: > >> > >>>On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sab

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Lukasz Marek
On 12.11.2014 20:32, Michael Niedermayer wrote: On Wed, Nov 12, 2014 at 06:31:52PM +0100, Lukasz Marek wrote: On 12 November 2014 17:53, Michael Niedermayer wrote: On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George en

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 06:31:52PM +0100, Lukasz Marek wrote: > On 12 November 2014 17:53, Michael Niedermayer wrote: > > > On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: > > > On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > > > > Le primidi 21 brumaire,

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Lukasz Marek
On 12 November 2014 17:53, Michael Niedermayer wrote: > On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: > > On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > > > Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > > > > +static int ffm_write_header_

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 05:47:01PM +0100, Stefano Sabatini wrote: > On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > > Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > > > +static int ffm_write_header_codec_private_ctx(AVIOContext *pb, void > > > *priv_data, int t

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Stefano Sabatini
On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded: > Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > > +static int ffm_write_header_codec_private_ctx(AVIOContext *pb, void > > *priv_data, int type) > > +{ > > +AVIOContext *tmp; > > +char *buf = NULL; > > + >

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-12 Thread Nicolas George
Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit : > +static int ffm_write_header_codec_private_ctx(AVIOContext *pb, void > *priv_data, int type) > +{ > +AVIOContext *tmp; > +char *buf = NULL; > + > +if (priv_data) { > +if (avio_open_dyn_buf(&tmp) < 0) > +re

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 11:59:32PM +0100, Lukasz Marek wrote: > On 11.11.2014 14:46, Michael Niedermayer wrote: > >the muxer might run in a seperate thread from the encoder, priv_data > >could change while its being accessed, iam not sure if that would > >cause some race here or not > > Wouldn't i

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-11 Thread Lukasz Marek
On 11.11.2014 14:46, Michael Niedermayer wrote: the muxer might run in a seperate thread from the encoder, priv_data could change while its being accessed, iam not sure if that would cause some race here or not Wouldn't it regard AVCodecContext.variables too? Also i dont think its guranteed t

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:25AM +0100, Lukasz Marek wrote: > TODO: bump micro > > Signed-off-by: Lukasz Marek > --- > libavformat/ffmdec.c | 41 - > libavformat/ffmenc.c | 27 +-- > 2 files changed, 61 insertions(+), 7 deletions(

[FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-10 Thread Lukasz Marek
TODO: bump micro Signed-off-by: Lukasz Marek --- libavformat/ffmdec.c | 41 - libavformat/ffmenc.c | 27 +-- 2 files changed, 61 insertions(+), 7 deletions(-) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c index 448762b..