On 15.11.2014 19:59, Michael Niedermayer wrote:
On Sat, Nov 15, 2014 at 02:32:26AM +0100, Lukasz Marek wrote:
On 15.11.2014 01:24, Michael Niedermayer wrote:
+ /**
+ * String containing paris of key and values describing recommended
encoder configuration.
+ * Paris are separated by ','.
+ * Keys are separated from values by '='.
+ */
+ char *recommended_encoder_configuration;
this requires accessor functions for future ABI compatibility
also it should be documented what and who sets it, unless its
intended to be changed how its set then it could be documented later
when the final design is implemented
I added these accessors.
Note: I added this field in public API section. From this comment I
can suspect I should be private, so please verify.
yes and no
it should be moved to the end but thats because of bugs, i think
there are still some applications that access private fields and
we should avoid moving these
otherwise it could be argued to be on either side (public with a
note that access is only through the accessors or on the private
side)
OK, locally moved to the end.
I also locally changed ffmpeg_opt.c so it uses getter.
I pushed it back to github, as changes are minor.
I'm waiting for green light to push this patchset.
no objections from me
I will push tonight if no objections from others.
I work on another patchset. I have sent 2 patches from it.
If they are ok, they should be applied before this patchset, perfectly.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
