Re: [FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: Optimize has_trns code

2019-08-18 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 08:49:06AM +0200, Reimar Döffinger wrote: > On 18.08.2019, at 01:28, Michael Niedermayer wrote: > > > 30M cycles -> 5M cycles > > I see nothing wrong with it, but: > You could save reviewers a lot of time if you gave them a hint of what the > change > contains instead of

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: Optimize has_trns code

2019-08-17 Thread Reimar Döffinger
On 18.08.2019, at 01:28, Michael Niedermayer wrote: > 30M cycles -> 5M cycles I see nothing wrong with it, but: You could save reviewers a lot of time if you gave them a hint of what the change contains instead of them having to reverse-engineer. In this case for example something like "add inn

[FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: Optimize has_trns code

2019-08-17 Thread Michael Niedermayer
30M cycles -> 5M cycles Testcase: fate-rgbapng-4816 Testcase: 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg --- libavcodec/pngdec.c | 38 ++