Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 13:16 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-18 12:55:49) > > FTR and FWIW it was useful for me for identifying filters that can do > > more with commands than timeline enable/disable. > > And then what do you do with this list of filters?

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-18 Thread Anton Khirnov
Quoting Alexander Strasser via ffmpeg-devel (2024-10-18 12:55:49) > FTR and FWIW it was useful for me for identifying filters that can do > more with commands than timeline enable/disable. And then what do you do with this list of filters? -- Anton Khirnov ___

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 21:24 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 21:05:54) > > Still that functionality is useful > > How is it useful? It gives you no actionable information. Seems this was just applied already. FTR and FWIW it was useful for me for ident

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Nicolas George
Anton Khirnov (12024-10-15): > Most filters implementing the process_command() callback just use > the generic implementation - ff_filter_process_command(). So what > information does that flag actually give you? It gives the information that the filter is ready to deal with what ff_filter_process

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Anton Khirnov
Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 21:16:28) > On 2024-10-15 15:09 +0200, Anton Khirnov wrote: > > Quoting James Almer (2024-10-15 14:54:08) > > > On 10/15/2024 6:57 AM, Anton Khirnov wrote: > > > > avfilter_process_command() may or may not return ENOSYS whether that > > > > fl

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Anton Khirnov
Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 21:05:54) > Still that functionality is useful How is it useful? It gives you no actionable information. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 15:09 +0200, Anton Khirnov wrote: > Quoting James Almer (2024-10-15 14:54:08) > > On 10/15/2024 6:57 AM, Anton Khirnov wrote: > > > avfilter_process_command() may or may not return ENOSYS whether that > > > flag is set or not, so I don't see what exactly would it be useful for. > > >

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 10:37 +0200, epira...@gmail.com wrote: > > > On 15 Oct 2024, at 10:30, Anton Khirnov wrote: > > > Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 07:34:26) > >> On 2024-10-14 22:35 +0200, Anton Khirnov wrote: > >>> Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Anton Khirnov
Quoting James Almer (2024-10-15 14:54:08) > On 10/15/2024 6:57 AM, Anton Khirnov wrote: > > avfilter_process_command() may or may not return ENOSYS whether that > > flag is set or not, so I don't see what exactly would it be useful for. > > I see, although I wouldn't expect ENOSYS for any other ca

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread James Almer
On 10/15/2024 6:57 AM, Anton Khirnov wrote: Quoting James Almer (2024-10-14 22:48:12) On 10/14/2024 1:27 PM, Alexander Strasser via ffmpeg-devel wrote: On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: --- fftools/opt_commo

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Anton Khirnov
Quoting James Almer (2024-10-14 22:48:12) > On 10/14/2024 1:27 PM, Alexander Strasser via ffmpeg-devel wrote: > > On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: > >> On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > >>> --- > >>> fftools/opt_common.c | 4 +--- > >>> 1 file

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread epirat07
On 15 Oct 2024, at 10:30, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 07:34:26) >> On 2024-10-14 22:35 +0200, Anton Khirnov wrote: >>> Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:38) > It is documented in the header. I figured as

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Nicolas George
Anton Khirnov (12024-10-15): > headers, but that first requires to eliminate its use. Not an excuse to remove the feature it was used for at the same time, especially without warning about it. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Anton Khirnov
Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 07:34:26) > On 2024-10-14 22:35 +0200, Anton Khirnov wrote: > > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:38) > > > > It is documented in the header. > > > > > > I figured as much but couldn't find a hint in in avfilter.h >

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Nicolas George
James Almer (12024-10-14): > A new flag AVFILTER_FLAG_SUPPORT_COMMANDS that the user can check to ensure > a call to avfilter_process_command() will not return ENOSYS could be added. So you mean to have the same information twice in the source code of the filter: once as the process_command callba

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 22:35 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:38) > > > It is documented in the header. > > > > I figured as much but couldn't find a hint in in avfilter.h > > > > You changed it in a previous patch of this series or am I reading it

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread James Almer
On 10/14/2024 1:27 PM, Alexander Strasser via ffmpeg-devel wrote: On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: --- fftools/opt_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fftools/opt_c

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Anton Khirnov
Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:38) > > It is documented in the header. > > I figured as much but couldn't find a hint in in avfilter.h > > You changed it in a previous patch of this series or am I reading it wrong? I don't follow, I changed what? -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread James Almer
On 10/14/2024 1:36 PM, Nicolas George wrote: Alexander Strasser via ffmpeg-devel (12024-10-14): Learning question: How can we see this is a private field? I suppose “revert everything and start again properly designing things without loss of feature” will not be appreciated? No, it wont. Als

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 19:22 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 18:27:24) > > On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: > > > On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > > > > --- > > > > fftools/opt_common.c | 4 +--- > > >

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Anton Khirnov
Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 18:27:24) > On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: > > On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > > > --- > > > fftools/opt_common.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > >

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Nicolas George
Alexander Strasser via ffmpeg-devel (12024-10-14): > Learning question: How can we see this is a private field? I suppose “revert everything and start again properly designing things without loss of feature” will not be appreciated? Regards, -- Nicolas George _

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: > On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > > --- > > fftools/opt_common.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > > index 021ed75272

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Michael Niedermayer
On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > --- > fftools/opt_common.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > index 021ed75272..34da2cee7d 100644 > --- a/fftools/opt_common.c > +++ b/fftools/op

[FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Anton Khirnov
--- fftools/opt_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fftools/opt_common.c b/fftools/opt_common.c index 021ed75272..34da2cee7d 100644 --- a/fftools/opt_common.c +++ b/fftools/opt_common.c @@ -808,7 +808,6 @@ int show_filters(void *optctx, const char *opt,