lör 2024-03-30 klockan 17:02 +0100 skrev Andreas Rheinhardt:
> If you force reordering on our users, then this is a breaking change
Another thing that bears keeping in mind: sorting isn't consistent even
across demuxers that sort. Most sort by timestamp (SUB_SORT_TS_POS),
but vobsub sorts by byte
On 30/03/2024 17:02, Andreas Rheinhardt wrote:
Tomas Härdin:
lör 2024-03-30 klockan 15:49 +0100 skrev Nicolas George:
ASS demuxer sorts its packets because
there is no guarantee the text are sorted in the file
So? I'm making a normative argument.
Normative about what? The ASS specification
lör 2024-03-30 klockan 17:02 +0100 skrev Andreas Rheinhardt:
> > > ASS demuxer sorts its packets because
> > > there is no guarantee the text are sorted in the file
> >
> > So? I'm making a normative argument.
> >
>
> Normative about what? The ASS specification [1] explicitly says:
>
> "SSA doe
Tomas Härdin:
> lör 2024-03-30 klockan 15:49 +0100 skrev Nicolas George:
>> Tomas Härdin (12024-03-30):
>>> Players can implement sorting if they wish.
>>
>> API break.
>
> lavf's API provides no guarantees regarding presentation order
>>
>
>>> Finally I will note that sorting does not happen whe
Tomas Härdin (12024-03-30):
> lavf's API provides no guarantees regarding presentation order
It used to work, you are about to require new code from applications for
it to work. That is an API break, and pretending otherwise like you do
here is just a cop out.
> "Supposed to" is doing a lot of wo
lör 2024-03-30 klockan 15:49 +0100 skrev Nicolas George:
> Tomas Härdin (12024-03-30):
> > Players can implement sorting if they wish.
>
> API break.
lavf's API provides no guarantees regarding presentation order
>
> > Finally I will note that sorting does not happen when subtitles are
> > muxe
Tomas Härdin (12024-03-30):
> Players can implement sorting if they wish.
API break.
> One potential solution is to do this style of parsing when the input is
> non-seekable. But then we have the silly situation where streamed and
> non-streamed behavior differs considerably.
Sure, better break
lör 2024-03-30 klockan 12:44 +0100 skrev Nicolas George:
> Tomas Härdin (12024-03-30):
> > More interesting is fate-sub-srt-badsyntax. Despite the name it
> > doesn't
> > really have bad syntax, but its cues are in a random order. I guess
> > it
> > exists to test the cue sorting logic. But should
Tomas Härdin (12024-03-30):
> More interesting is fate-sub-srt-badsyntax. Despite the name it doesn't
> really have bad syntax, but its cues are in a random order. I guess it
> exists to test the cue sorting logic. But should subtitle demuxers
> really sort subtitles in this way? We don't do that f
On Sat, Mar 30, 2024 at 9:31 AM Tomas Härdin wrote:
> lör 2024-03-30 klockan 00:35 +0100 skrev Michael Niedermayer:
> > breaks fate here:
> >
> > --- ./tests/ref/fate/sub-srt-madness-timeshift 2024-03-29
> > 20:43:34.617419731 +0100
> > +++ tests/data/fate/sub-srt-madness-timeshift 2024-03-30
lör 2024-03-30 klockan 00:35 +0100 skrev Michael Niedermayer:
> breaks fate here:
>
> --- ./tests/ref/fate/sub-srt-madness-timeshift 2024-03-29
> 20:43:34.617419731 +0100
> +++ tests/data/fate/sub-srt-madness-timeshift 2024-03-30
Sorry but this file is utter crap and shouldn't be part of FATE.
lör 2024-03-30 klockan 00:35 +0100 skrev Michael Niedermayer:
> On Thu, Mar 28, 2024 at 11:57:57PM +0100, Tomas Härdin wrote:
> > Here as well
>
> > libavformat/srtdec.c | 211 --
> > -
> > tests/ref/fate/sub-srt-rrn-remux | 4
> > 2 files chan
On Thu, Mar 28, 2024 at 11:57:57PM +0100, Tomas Härdin wrote:
> Here as well
> libavformat/srtdec.c | 211
> ---
> tests/ref/fate/sub-srt-rrn-remux |4
> 2 files changed, 116 insertions(+), 99 deletions(-)
> 699d8b957286e190de6d5ca5cd17e67bb5
Here as well
From 6d0684ca6fe02d80fc07a622fb85445a6917c29f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=
Date: Thu, 28 Mar 2024 22:15:18 +0100
Subject: [PATCH 2/3] lavf/srtdec: Permit streaming input
This is largely a rewrite.
Read packets in srt_read_packet() rather than readin
I am once again asking more people on this list to peruse
https://langsec.org/
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@
15 matches
Mail list logo
